Skip to content

fix(name): change resource name length limit from 64 to 128 - #839

Merged
yizhouxw merged 2 commits into
dev/4.2.2from
bugfix/gaoda_42x_resource_name_length_limit
Nov 15, 2023
Merged

yizhouxw merged 2 commits into
dev/4.2.2from
bugfix/gaoda_42x_resource_name_length_limit

Conversation

@smallsheeeep

Copy link
Copy Markdown
Contributor

What type of PR is this?

type-bug

What this PR does / why we need it:

In cloud mode, the user name may longer than 64 chars. This PR change resource name length limit from 64 to 128.

@smallsheeeep smallsheeeep added this to the ODC 4.2.2-bp milestone Nov 14, 2023
@smallsheeeep smallsheeeep self-assigned this Nov 14, 2023
yhilmare
yhilmare previously approved these changes Nov 14, 2023

@yhilmare yhilmare left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yizhouxw
yizhouxw merged commit 17439a7 into dev/4.2.2 Nov 15, 2023
@smallsheeeep
smallsheeeep deleted the bugfix/gaoda_42x_resource_name_length_limit branch January 3, 2024 05:51
yhilmare pushed a commit that referenced this pull request Jan 15, 2024
* fix: resource name length limit

* trigger ut
LordofAvernus added a commit to actiontech/odc that referenced this pull request May 29, 2026
Without these two rows in odc_version_diff_config the front-end
supportFeature.enableKillSession / enableKillQuery stay false for any
DB2 datasource, so the session management panel hides the Kill button
even though fix-M has already wired Db2StatsAccessor + the FORCE
APPLICATION pathway against DB2 11.5 LUW (case 6.2 / O2).

Pattern mirrors the SQL_SERVER / DORIS always-on rows (min_version='0').

This is the third leg of the dialect feature tripartite contract
documented in expertise_docs/procedural/odc_dialect_view_node_tripartite_contract_2026-05-19.md:

  1. SchemaAccessor SQL    -> Db2StatsAccessor (fix-M)
  2. ExtensionPoint        -> Db2SessionExtension (existing)
  3. MetaDB seed           -> this commit

Fixes oceanbase#839
Issue: dms-ee#839
Seechi-Yolo pushed a commit to Seechi-Yolo/odc that referenced this pull request Jun 1, 2026
Without these two rows in odc_version_diff_config the front-end
supportFeature.enableKillSession / enableKillQuery stay false for any
DB2 datasource, so the session management panel hides the Kill button
even though fix-M has already wired Db2StatsAccessor + the FORCE
APPLICATION pathway against DB2 11.5 LUW (case 6.2 / O2).

Pattern mirrors the SQL_SERVER / DORIS always-on rows (min_version='0').

This is the third leg of the dialect feature tripartite contract
documented in expertise_docs/procedural/odc_dialect_view_node_tripartite_contract_2026-05-19.md:

  1. SchemaAccessor SQL    -> Db2StatsAccessor (fix-M)
  2. ExtensionPoint        -> Db2SessionExtension (existing)
  3. MetaDB seed           -> this commit

Fixes oceanbase#839
Issue: dms-ee#839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants