faceted grid - #98
Closed
Fil wants to merge 1 commit into
Closed
faceted grid#98Fil wants to merge 1 commit into
Fil wants to merge 1 commit into
Conversation
TODO: make the grid the *first* layer of the facet (rather than the last).
Member
|
Superseded by #101. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the approach where the grid becomes a mark.
(It doesn't work completely because I'm pushing it to the top of the facets' marks array. It ought to be at the bottom, but this means that I'd have to unshift the markIndex arrays etc.)
In any case this helped me get a clearer view of the issue, and I'll try and go back to the original approach (a path which intelligently skips over empty facets).