font-variant on the axes - #606
Merged
Merged
Conversation
…riant option, which defaults to tabular-nums closes #601
Contributor
Author
|
A comment: for Plot.text, I think it would be too magical to do auto-detection, and it's easy enough to use the fontVariant option. This PR removes font-variant from the static styles, and introduces a new axis option called fontVariant, which defaults to tabular-nums. (Just moving the static style to the axis wouldn't allow to undo the feature… and this approach seemed more consistent with our general patterns.) |
mbostock
requested changes
Dec 10, 2021
mbostock
left a comment
mbostock
left a comment
Member
There was a problem hiding this comment.
Nice! But I think we should only default to tabular-nums for quantitative (and probably also temporal?) scales. For categorical/ordinal scales, we should default to normal.
Co-authored-by: Mike Bostock <mbostock@gmail.com>
Co-authored-by: Mike Bostock <mbostock@gmail.com>
mbostock
reviewed
Dec 10, 2021
mbostock
approved these changes
Dec 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove font-variant from the global styles; introduce the axis fontVariant option, which defaults to tabular-nums
closes #601