Skip to content

document the default height - #529

Closed
Fil wants to merge 3 commits into
mainfrom
fil/default-height
Closed

Fil wants to merge 3 commits into
mainfrom
fil/default-height

Conversation

@Fil

@Fil Fil commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

@Fil Fil mentioned this pull request Sep 3, 2021
@mbostock

mbostock commented Sep 7, 2021

Copy link
Copy Markdown
Member

I like the notebook, but I’m tempted to make the README description more hand-wavy. I feel like either we explicit document the logic in pseudocode, or we just leave it vague like: “If a height is not specified, Plot will attempt to chose a reasonable default height based on the y and fy scale types and, for ordinal scales, the cardinality of the domain. The default height ranges from TK to TK, with 400 for the common case where y is quantitative and fy is not present.”

@Fil

Fil commented Sep 7, 2021

Copy link
Copy Markdown
Contributor Author

We could publish the notebook and link to it for details.

@Fil

Fil commented May 31, 2022

Copy link
Copy Markdown
Contributor Author

(Notebook further updated to take #837 into account.)

@Fil

Fil commented Mar 3, 2023

Copy link
Copy Markdown
Contributor Author

18 months later, it's published :) https://observablehq.com/@observablehq/plot-default-height

EDIT the URL above was redirected to the documentation, see new URL: https://observablehq.com/d/f7ce87cd798d9674

@Fil Fil closed this Mar 3, 2023
@Fil
Fil deleted the fil/default-height branch March 3, 2023 08:48
@Fil Fil added the documentation Improvements or additions to docs label Mar 3, 2023
@Fil
Fil restored the fil/default-height branch March 3, 2023 08:49
@Fil

Fil commented Mar 3, 2023

Copy link
Copy Markdown
Contributor Author

didn't mean to close the PR!

@Fil Fil reopened this Mar 3, 2023
@Fil
Fil requested a review from mbostock March 3, 2023 08:49
@Fil
Fil force-pushed the fil/default-height branch from be41a18 to 327f0d1 Compare March 3, 2023 08:59
@Fil
Fil force-pushed the fil/default-height branch from a465155 to 54218aa Compare April 27, 2023 22:35
Comment thread docs/features/plots.md Outdated
@Fil

Fil commented Sep 9, 2024

Copy link
Copy Markdown
Contributor Author

closing, it seems ok to not document this more in depth

@Fil Fil closed this Sep 9, 2024
@Fil
Fil deleted the fil/default-height branch September 9, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants