Skip to content

empty facets - #516

Merged
mbostock merged 7 commits into
mainfrom
fil/empty-facets
Aug 20, 2021
Merged

mbostock merged 7 commits into
mainfrom
fil/empty-facets

Conversation

@Fil

@Fil Fil commented Aug 20, 2021

Copy link
Copy Markdown
Contributor

empty facet logic, broken out of #332

  • in axis.js, do not extend the grid on empty slots
  • in facet.js, only render marks if the facet exists

@Fil
Fil requested a review from mbostock August 20, 2021 14:31
@mbostock
mbostock force-pushed the fil/empty-facets branch 2 times, most recently from 29ce3f2 to 06a3689 Compare August 20, 2021 14:56
@mbostock
mbostock merged commit 5c5b868 into main Aug 20, 2021
@mbostock
mbostock deleted the fil/empty-facets branch August 20, 2021 15:16
@mbostock mbostock mentioned this pull request Aug 20, 2021
@Fil Fil mentioned this pull request Aug 20, 2021
3 tasks
@Fil

Fil commented Aug 20, 2021

Copy link
Copy Markdown
Contributor Author

image for the CHANGELOG

empty-facet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants