a few changes - #511
Merged
Merged
a few changes#511
Conversation
Fil
commented
Aug 19, 2021
Fil
commented
Contributor
- README document sort x by y
- first ladies example plot (by @tophtucker )
- add limit: [lo, hi]
- throw the correct error if a mistaken sort option is given as {x: "-y", limit: 10}
Fil
commented
Aug 19, 2021
Comment on lines
+88
to
+90
| if (limit !== undefined) { | ||
| domain = domain.slice(...typeof limit === "object" ? [limit[0], limit[1]] : [0, limit]); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
here in fact we could be more lazy, since slice(0, undefined) returns the same array.
I the case of limit being an array, I chose to pass [limit[0], limit[1]] rather than limit, but it may be too superstitious
Merged
mbostock
added a commit
that referenced
this pull request
Aug 19, 2021
* sortX, sortY (rebased) * stricter reduce interpretation * prepare channel sorting in mark.initialize * allow channels to imply domains * remove unused variable * use group reducers * use groupSort * mark order option * remove unused order option * order options * fix reverse order * order ↦ sort * isOptions * reverse shorthand * alias sort channels * shorten * better error for unknown scale * a few changes (#511) * throw the correct error if a mistaken sort option is given as {x: "-y", limit: 10} * first ladies example plot (demonstrates "group names by first tenure_start") based on Toph Tucker’s https://observablehq.com/@tophtucker/first-ladies-of-the-united-states * document sort x by y * add limit: [lo, hi] * update README * update README * update README * update README * update README * update README * update README * update README * order facet channels, too * update README * add googleTrendsRidgeline test * min- and max-index * negative limit; iterable test * update README * coerce to string once * coerce to string * replace ±channel with shared sort options * update README Co-authored-by: Mike Bostock <mbostock@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.