Skip to content

alternative to bin{filter} : bin {transform} - #497

Closed
Fil wants to merge 1 commit into
mbostock/empty-binsfrom
fil/transform-bins
Closed

Fil wants to merge 1 commit into
mbostock/empty-binsfrom
fil/transform-bins

Conversation

@Fil

@Fil Fil commented Aug 11, 2021

Copy link
Copy Markdown
Contributor

what if we did something totally different and passed the actual bin to a transform option?

  • the default might be transform: bin => bin.length ? bin : null which would remove empty bins.
  • using transform: bin => bin or transform: "identity" ("keep-empty"), would keep empty bins
  • using transform: bin => bin.length < 20 ? null : bin would do for athletesHeightWeightBinStroke

Ref #495 (comment)

@Fil
Fil requested a review from mbostock August 11, 2021 11:14
@mbostock

Copy link
Copy Markdown
Member

Thanks for the suggestion! Closing in favor of #495 (comment).

@mbostock mbostock closed this Aug 11, 2021
@Fil
Fil deleted the fil/transform-bins branch January 24, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants