Explicit transform options - #494
Merged
Merged
Conversation
This was referenced Aug 10, 2021
Closed
mbostock
force-pushed
the
mbostock/normalize-shorthand
branch
from
August 10, 2021 22:38
762f784 to
addf7fe
Compare
Fil
approved these changes
Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows transform options to be kept separate from passthrough options, as well as shorthand options for the normalize and window transforms. Explicit transform options can disambiguate the intended recipient of the options, which could be a specific transform in a sequence of transforms or the output mark. This is especially important for the stack option’s reverse option, which overlaps with the basic reverse transform.
Supersedes #480.
Supersedes #439.
Related #472.
Fixes #479.