Fil/grid facet - #293
Closed
Fil wants to merge 5 commits into
Closed
Fil/grid facet#293Fil wants to merge 5 commits into
Fil wants to merge 5 commits into
Conversation
rebase 2ff3c4c
We still have to struggle a bit to remove the automatic (and now meaningless) facet labels, and position our own facet labels in each frame.
Fil
marked this pull request as ready for review
April 13, 2021 17:06
Fil
added a commit
that referenced
this pull request
Apr 19, 2021
Contributor
Author
|
superseded by #332 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #277
todo:
cleaner method to add the facets' ticks in a proper placepending question
facet: {data, xy: accessor}or something.