Generic sort and filter transforms. - #205
Merged
Merged
Conversation
Fil
approved these changes
Mar 9, 2021
Fil
left a comment
Fil
left a comment
Contributor
There was a problem hiding this comment.
Wow this is great!
Very nice that we we can filter and sort. One thing that might need an error message is if sort or filter are ignored because of a (more explicit, more generic) transform.
This was referenced Mar 9, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #203.
Fixes #180.
Fixes #179.
Fixes #138.
Because this happens at the maybeTransform layer, all the built-in transforms such as stack now support the sort and filter options, too.