z bin - #196
Merged
Merged
z bin#196
Conversation
Member
Author
|
It works! 👏
Plot.plot({
x: {
round: true,
label: "Body mass (g) →"
},
y: {
grid: true
},
marks: [
Plot.rect(data, Plot.stackY(Plot.binX({x: "body_mass_g", fill: "species"}))),
Plot.ruleY([0])
]
}) |
Contributor
|
I've generalized this to 2d bins in #198, and allowed to specify thresholds_x and thresholds_y separately. I think a later step would be to allow mixing x binning with y grouping (and vice-versa). I'm strongly biased towards unifying grouping and various systems of binning (uniform, jenks…) into a unique operator. |
Fil
approved these changes
Mar 8, 2021
* generealize z-bin1 to z-bin2 example http://localhost:8008/?test=penguinSexMassCulmenSpecies remove unused functions * allow separate thresholds_x and thresholds_y (most useful when we want to specify them as arrays of values) * a grid to match the binning * tweaks Co-authored-by: Mike Bostock <mbostock@gmail.com>
mbostock
added a commit
that referenced
this pull request
Mar 8, 2021
* composable transform * fix crash on const z * remove basic transform support * normalize transform * remove unused import * movingAverage transform * propagate computed channels * stack transform * preserve data during select * fix select * simpler composite transform * fix select, normalize * restore stack transform * restore movingAverage transform * minimize diff * revert tests * restore group transform * fix tests * restore bin transform * fix label * shorter * cleaner * cleaner bin * more flexible rect[XY] * z bin (#196) * z bin * z, x1 inheritance * stacked bin test * use rectY * more TODO * x1, y1 inheritance * bins as grouped data * fix x inheritance * bin1 normalize * simplify * reorder * bin-z for 2D bins (#198) * generealize z-bin1 to z-bin2 example http://localhost:8008/?test=penguinSexMassCulmenSpecies remove unused functions * allow separate thresholds_x and thresholds_y (most useful when we want to specify them as arrays of values) * a grid to match the binning * tweaks Co-authored-by: Mike Bostock <mbostock@gmail.com> Co-authored-by: Philippe Rivière <fil@rezo.net> * format * group1 sort by x * group2 * rename * consolidate * fix #201; group domain option Co-authored-by: Philippe Rivière <fil@rezo.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref. #195 (comment)
A little cumbersome to implement, but it seems to work, and I think I can clean it up. Still need to implement z inheriting from fill or stroke as needed.