Conversation
…{className: "my class"} in the options.
Member
|
I think I’d be more comfortable with this if className was optional and had no default value, so you have to decide what names you want to use and there are no implicit classes. |
Contributor
Author
|
I had the following "spec" in mind: "Having a class based on the mark type sound reasonable". But I don't have a strong preference, and the code will be leaner without all the default classes. One argument against default classes is that users will then want them to stay even when they add their own :) |
Member
|
It’s always easier to add something than to take something away, too. |
mbostock
requested changes
Feb 24, 2021
mbostock
left a comment
mbostock
left a comment
Member
There was a problem hiding this comment.
I would support this as an optional className but I don’t think mark types should provide a default className.
Contributor
Author
|
superseded by #253 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a className on all marks, facets and axes; override by setting {className: "my class"} in the options.
Demo: https://observablehq.com/d/44f1024cb20f8a0d
If I then promote all classes to ids, it gives the following structure in Illustrator
