feat: added internal database option to project addition - #52
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The create-project payload now always sends internalDatabase: false when no database is provided, which can alter API compatibility/semantics and should be made backward-safe (and covered by tests).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds an “internal database” option when creating Opal projects via the Python client/CLI, and bumps the package version to 6.2.0 alongside a few formatting/doc touch-ups.
Changes:
- Add
--internal/-ioption (argparse + Typer CLI) and plumb it intoProjectService.add_project(). - Include an
internalDatabaseflag in the project creation payload when no explicitdatabaseis provided. - Version bump to
6.2.0plus minor formatting updates (README example, docstring, request chaining).
File summaries
| File | Description |
|---|---|
| uv.lock | Bumps locked package version to 6.2.0. |
| README.md | Reformats example code (string quoting / line wrapping). |
| pyproject.toml | Bumps project version to 6.2.0. |
| obiba_opal/system.py | Docstring formatting adjustment. |
| obiba_opal/project.py | Adds --internal option and includes internalDatabase in create-project payload. |
| obiba_opal/file.py | Refactors request chaining formatting and simplifies options dict formatting. |
| obiba_opal/commands.py | Adds Typer CLI --internal/-i option and passes it through. |
Review details
- Files reviewed: 5/7 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.