Skip to content

fix(nuxt): ensure static presets equivalent to nuxi generate - #21860

Merged
danielroe merged 2 commits into
mainfrom
fix/explicit-static
Jun 29, 2023
Merged

fix(nuxt): ensure static presets equivalent to nuxi generate#21860
danielroe merged 2 commits into
mainfrom
fix/explicit-static

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #21254

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This finishes the second task on #21254. Previous we enabled static nitro preset in nuxi generate (#21655), but this follows up to ensure that running nuxi build --prerender (or NITRO_PRESET=static nuxi build have the same behaviour.

From this point, we no longer use options._generate flag but directly access nitro.options.static. We can remove the internal ._generate flag in a future minor release.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added 3.x 🐛 bug Something isn't working as expected 🔨 p3-minor Minor issue, should be fixed labels Jun 29, 2023
@danielroe
danielroe requested a review from pi0 June 29, 2023 09:02
@danielroe danielroe self-assigned this Jun 29, 2023
@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pi0 pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes

@danielroe danielroe changed the title fix(nuxt): ensure static presets are equivalent to nuxi generate fix(nuxt): ensure static presets equivalent to nuxi generate Jun 29, 2023
@danielroe
danielroe merged commit 669e9bc into main Jun 29, 2023
@danielroe
danielroe deleted the fix/explicit-static branch June 29, 2023 09:14
@github-actions github-actions Bot mentioned this pull request Jun 29, 2023
@Hebilicious

Copy link
Copy Markdown
Member

Does this means that nuxi generate is now strictly an alias of nuxi build --prerender ?

@danielroe

Copy link
Copy Markdown
Member Author

Yes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x 🐛 bug Something isn't working as expected 🔨 p3-minor Minor issue, should be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

static nitro builds when running nuxi generate

3 participants