Skip to content

fix(pip): check for https support #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antfu merged 1 commit into from
Nov 21, 2023
Merged

fix(pip): check for https support #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/devtools/client/components/PictureInPictureButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
const client = useClient()

const isInPopup = window.__NUXT_DEVTOOLS_IS_POPUP__
const isHttps = computed(() => window.location.protocol === 'https:')

const showInfo = ref(false)
const copy = useCopy()
Expand All @@ -17,7 +18,7 @@ function popup() {

<template>
<template v-if="!isInPopup">
<NButton v-if="client?.devtools.popup" n="sm primary" @click="popup()">
<NButton v-if="client?.devtools.popup && isHttps" n="sm primary" @click="popup()">
<div carbon-launch /> Popup
</NButton>
<template v-else>
Expand Down Expand Up @@ -45,6 +46,12 @@ function popup() {
</NButton>
and restart the browser.
</p>
<NTip v-if="!isHttps" class="mb-4" n="orange">
Please note that the popup feature only works when your server is running under HTTPS.
<NuxtLink to="https://nuxt.com/docs/api/nuxt-config#https" target="_blank">
Learn how to run your server with https on Nuxt's Documentation
</NuxtLink>
</NTip>
<div>
<NButton @click="showInfo = false">
Close
Expand Down
Empty file removed packages/devtools/client/components/PictureInPictureInfoDialog.vue
View file
Open in desktop
Empty file.