Skip to content

fix(dev): handle nuxt v5 for the new interactive ui - #1473

Merged
danielroe merged 3 commits into
mainfrom
fix/nuxt-nightly
Aug 23, 2026
Merged

fix(dev): handle nuxt v5 for the new interactive ui#1473
danielroe merged 3 commits into
mainfrom
fix/nuxt-nightly

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

thanks to @onmax for spotting, this handles an issue where the runtime from nuxt/cli was caught by impound.

there's another PR coming soon to get logs to be properly attributed...

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 23 minutes.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 98c4cf11-af1a-4343-a920-f065b8a960ec

📥 Commits

Reviewing files that changed from the base of the PR and between b674b63 and c4b5438.

📒 Files selected for processing (2)
  • packages/nuxt-cli/runtime/dev-request-context.mjs
  • packages/nuxt-cli/src/dev/utils.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Aug 23, 2026

Copy link
Copy Markdown
  • nuxt-cli-playground

    npm i https://pkg.pr.new/create-nuxt@1473
    
    npm i https://pkg.pr.new/nuxi@1473
    
    npm i https://pkg.pr.new/@nuxt/cli@1473
    

commit: c4b5438

@github-actions

Copy link
Copy Markdown
Contributor

CLI benchmark

@nuxt/cli v3.37.0 (baseline) vs v3.37.0 (this PR)

Metric baseline v3.37.0 head v3.37.0 Delta
nuxt --version wall time (median) 67 ms 67 ms -0.8%
nuxt --help wall time (median) 137 ms 141 ms +2.9%
nuxt dev --help wall time (median) 107 ms 107 ms +0.2%
nuxt --version modules loaded 38 38 0.0%
nuxt --help modules loaded 135 135 0.0%
nuxt dev --help modules loaded 80 80 0.0%
Installed node_modules 2.31 MB 2.31 MB +0.1%
Published tarball (packed) 263.0 kB 263.4 kB +0.1%
Full report

@nuxt/cli v3.37.0 (baseline) vs v3.37.0 (head)

Setting Value
Baseline ref:b674b6304a8cda1a7008d14d9fb7a2b1a8b7f4a0 (v3.37.0)
Head local packages/nuxt-cli at 69d2ad5 (v3.37.0)
Node v24.19.0
OS Linux 6.17.0 (kernel 6.17.0-1022-azure)
CPU AMD EPYC 9V74 80-Core Processor x 4
Memory 15.6 GB
Load average at start 0.74, 0.22, 0.08
Run started 2026-08-23T20:30:25.208Z

Cold CLI startup

Median of 15 interleaved runs per command, one warmup discarded.

Command baseline v3.37.0 median head v3.37.0 median Delta baseline v3.37.0 min / p95 head v3.37.0 min / p95
nuxt --version 67 ms 67 ms -0.8% 64 ms / 74 ms 63 ms / 80 ms
nuxt --version (first output byte) 62 ms 62 ms -0.4% 60 ms / 69 ms 59 ms / 76 ms
nuxt --help 137 ms 141 ms +2.9% 134 ms / 146 ms 136 ms / 153 ms
nuxt --help (first output byte) 131 ms 135 ms +3.2% 128 ms / 139 ms 130 ms / 148 ms
nuxt dev --help 107 ms 107 ms +0.2% 102 ms / 110 ms 103 ms / 117 ms
nuxt dev --help (first output byte) 102 ms 102 ms +0.5% 97 ms / 105 ms 98 ms / 112 ms
nuxt <unknown-command> (no-op) 147 ms 147 ms -0.0% 144 ms / 152 ms 144 ms / 158 ms
nuxt <unknown-command> (no-op) (first output byte) 142 ms 142 ms -0.1% 138 ms / 146 ms 138 ms / 151 ms

Module load cost

Counted with a module.registerHooks load hook, compile cache disabled. Counts every JS module actually evaluated on that code path (built-ins excluded, native addons excluded).

Command baseline v3.37.0 modules head v3.37.0 modules Delta baseline v3.37.0 source bytes head v3.37.0 source bytes Delta
nuxt --version 38 38 0.0% 291.6 kB 291.6 kB 0.0%
nuxt --help 135 135 0.0% 972.6 kB 973.3 kB +0.1%
nuxt dev --help 80 80 0.0% 581.9 kB 582.6 kB +0.1%

Install footprint and published tarball

Each version installed on its own into an empty project with nothing but @nuxt/cli as a dependency, so the tree is exactly the CLI and its transitive dependencies. npm cache is warm and the registry is only consulted for metadata, so install wall time is indicative, not a network benchmark.

Metric baseline v3.37.0 head v3.37.0 Delta
Direct dependencies of @nuxt/cli 21 21 0.0%
Packages in the installed tree (unique name@version) 34 34 0.0%
Unique package names 34 34 0.0%
Package directories on disk (cross-check) 28 28 0.0%
Installed node_modules on disk 2.31 MB 2.31 MB +0.1%
Installed files 419 419 0.0%
Install wall time (warm npm cache, median of 3) 668 ms 662 ms -1.0%
Published tarball (packed) 263.0 kB 263.4 kB +0.1%
Published tarball (unpacked) 915.6 kB 916.8 kB +0.1%
Files in tarball 131 131 0.0%

Interleaved runs on a shared runner: trust the deltas, not the absolute timings. The dev, restart and build suites run locally via pnpm bench:cli.

@codspeed-hq

codspeed-hq Bot commented Aug 23, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 2 untouched benchmarks


Comparing fix/nuxt-nightly (c4b5438) with main (b674b63)

Open in CodSpeed

@danielroe
danielroe added this pull request to the merge queue Aug 23, 2026
Merged via the queue into main with commit b5462dc Aug 23, 2026
23 checks passed
@danielroe
danielroe deleted the fix/nuxt-nightly branch August 23, 2026 21:00
@github-actions github-actions Bot mentioned this pull request Aug 23, 2026
This was referenced Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant