Skip to content

fix: add value hints to string args - #1468

Merged
danielroe merged 1 commit into
mainfrom
fix/add-value-hints
Aug 23, 2026
Merged

fix: add value hints to string args#1468
danielroe merged 1 commit into
mainfrom
fix/add-value-hints

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

aim is to improve DX 🚀

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@danielroe, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d0c878d-ce1c-4e8d-a674-a855df38f75d

📥 Commits

Reviewing files that changed from the base of the PR and between b4581c7 and 5cb2c5f.

📒 Files selected for processing (9)
  • packages/create-nuxt/src/init.ts
  • packages/nuxt-cli/src/commands/_shared.ts
  • packages/nuxt-cli/src/commands/build.ts
  • packages/nuxt-cli/src/commands/dev.ts
  • packages/nuxt-cli/src/commands/generate.ts
  • packages/nuxt-cli/src/commands/module/add.ts
  • packages/nuxt-cli/src/commands/preview.ts
  • packages/nuxt-cli/src/commands/typecheck.ts
  • packages/nuxt-cli/test/unit/help.spec.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Aug 23, 2026

Copy link
Copy Markdown
  • nuxt-cli-playground

    npm i https://pkg.pr.new/create-nuxt@1468
    
    npm i https://pkg.pr.new/nuxi@1468
    
    npm i https://pkg.pr.new/@nuxt/cli@1468
    

commit: 5cb2c5f

@github-actions

Copy link
Copy Markdown
Contributor

CLI benchmark

@nuxt/cli v3.37.0 (baseline) vs v3.37.0 (this PR)

Metric baseline v3.37.0 head v3.37.0 Delta
nuxt --version wall time (median) 65 ms 64 ms -2.0%
nuxt --help wall time (median) 139 ms 140 ms +0.7%
nuxt dev --help wall time (median) 107 ms 104 ms -2.7%
nuxt --version modules loaded 38 38 0.0%
nuxt --help modules loaded 135 135 0.0%
nuxt dev --help modules loaded 80 80 0.0%
Installed node_modules 2.31 MB 2.31 MB +0.0%
Published tarball (packed) 262.7 kB 262.9 kB +0.1%
Full report

@nuxt/cli v3.37.0 (baseline) vs v3.37.0 (head)

Setting Value
Baseline ref:b4581c719bfc4d12916489331712d1938b5c3c03 (v3.37.0)
Head local packages/nuxt-cli at 6a9f645 (v3.37.0)
Node v24.19.0
OS Linux 6.17.0 (kernel 6.17.0-1022-azure)
CPU AMD EPYC 7763 64-Core Processor x 4
Memory 15.6 GB
Load average at start 1.19, 0.29, 0.10
Run started 2026-08-23T18:07:37.888Z

Cold CLI startup

Median of 15 interleaved runs per command, one warmup discarded.

Command baseline v3.37.0 median head v3.37.0 median Delta baseline v3.37.0 min / p95 head v3.37.0 min / p95
nuxt --version 65 ms 64 ms -2.0% 62 ms / 68 ms 62 ms / 67 ms
nuxt --version (first output byte) 61 ms 59 ms -2.0% 58 ms / 64 ms 58 ms / 63 ms
nuxt --help 139 ms 140 ms +0.7% 133 ms / 142 ms 136 ms / 144 ms
nuxt --help (first output byte) 134 ms 135 ms +0.6% 129 ms / 136 ms 131 ms / 138 ms
nuxt dev --help 107 ms 104 ms -2.7% 103 ms / 112 ms 103 ms / 107 ms
nuxt dev --help (first output byte) 102 ms 99 ms -2.6% 98 ms / 106 ms 99 ms / 102 ms
nuxt <unknown-command> (no-op) 150 ms 150 ms -0.3% 145 ms / 153 ms 145 ms / 163 ms
nuxt <unknown-command> (no-op) (first output byte) 144 ms 145 ms +0.1% 140 ms / 148 ms 140 ms / 158 ms

Module load cost

Counted with a module.registerHooks load hook, compile cache disabled. Counts every JS module actually evaluated on that code path (built-ins excluded, native addons excluded).

Command baseline v3.37.0 modules head v3.37.0 modules Delta baseline v3.37.0 source bytes head v3.37.0 source bytes Delta
nuxt --version 38 38 0.0% 291.6 kB 291.6 kB +0.0%
nuxt --help 135 135 0.0% 971.6 kB 972.4 kB +0.1%
nuxt dev --help 80 80 0.0% 581.6 kB 581.9 kB +0.0%

Install footprint and published tarball

Each version installed on its own into an empty project with nothing but @nuxt/cli as a dependency, so the tree is exactly the CLI and its transitive dependencies. npm cache is warm and the registry is only consulted for metadata, so install wall time is indicative, not a network benchmark.

Metric baseline v3.37.0 head v3.37.0 Delta
Direct dependencies of @nuxt/cli 21 21 0.0%
Packages in the installed tree (unique name@version) 34 34 0.0%
Unique package names 34 34 0.0%
Package directories on disk (cross-check) 28 28 0.0%
Installed node_modules on disk 2.31 MB 2.31 MB +0.0%
Installed files 419 419 0.0%
Install wall time (warm npm cache, median of 3) 698 ms 702 ms +0.5%
Published tarball (packed) 262.7 kB 262.9 kB +0.1%
Published tarball (unpacked) 914.5 kB 915.3 kB +0.1%
Files in tarball 131 131 0.0%

Interleaved runs on a shared runner: trust the deltas, not the absolute timings. The dev, restart and build suites run locally via pnpm bench:cli.

@codspeed-hq

codspeed-hq Bot commented Aug 23, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 2 untouched benchmarks


Comparing fix/add-value-hints (5cb2c5f) with main (b4581c7)

Open in CodSpeed

@danielroe
danielroe added this pull request to the merge queue Aug 23, 2026
Merged via the queue into main with commit 2f6f319 Aug 23, 2026
23 checks passed
@danielroe
danielroe deleted the fix/add-value-hints branch August 23, 2026 18:23
This was referenced Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant