Repository navigation
Tracking eval - Fix motmetrics version - #300
Merged
Merged
Conversation
venice-erin
approved these changes
Feb 18, 2020
|
Will the code be updated to motmetrics 1.2.0? |
Contributor
Author
|
@tobiasfshr We don't intend to. Apparently motmetrics was completely rewritten and is not backward compatible. Is there a strong reason to switch to 1.2.0 ? |
|
@holger-nutonomy In my case, I'm using a codebase that requires motmetrics 1.2.0, so i cannot run the nuscenes eval code inside of it. In general, the release log of v1.2.0 indicates that it would be way faster and, more importantly, they seem to have fixed a number of edge cases where the current evaluation results could be invalid. I'm not super similar with the repo though, so I can't say for sure if it makes a difference :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #299. Major changes in the new motmetrics version
1.2.0break our tracking eval code. To ensure that the results of our tracking challenge do not change, we fix the version number to be<= 1.1.3.