Repository navigation
Conversation
By splitting the executor out of the main server binary. It's possible to apply better permissions on it. It also fixes the os.Chdir() issue with the Lua executor that could allow 2 different scripts to write at the same place. By default the worker doesn't a PATH variable set. This is were the -wenv switch comes in as it allows to write a file containing all the environment variables the worker should have. - Binary created under cmd/worker - Reworked NixOS module to compensate - Add integration tests using runNixosTest - Fix missing folders not being created by the NixOS module - The module doesn't set -etcdurl and -nats if not needed - flake: Package set is now created by a function so it will be equal accross the different architectures.
- Unify the tests into a single file per backend - Shared fixtures are in fixtures.nix - Add username/password/policy for pulls in the json - Fixes on the podman executor itself - Properly set XDG_RUNTIME_DIR/HOME on the service - Podman executor will use the podman root socket by default - Update podman Go bindings to latest version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By splitting the executor out of the main server binary. It's possible
to apply better permissions on it. It also fixes the os.Chdir() issue
with the Lua executor that could allow 2 different scripts to write at
the same place. By default the worker doesn't a PATH variable set. This
is were the -wenv switch comes in as it allows to write a file
containing all the environment variables the worker should have.
accross the different architectures.