Skip to content

feat: allow disabling AI-generated thread titles #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nullStack65 merged 2 commits into from
Sep 23, 2026
Merged

feat: allow disabling AI-generated thread titles #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13622f9
feat(settings): allow disabling AI-generated thread titles
nullStack65 Sep 22, 2026
baba583
fix(settings): restore AI thread titles with global defaults
nullStack65 Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
235 changes: 234 additions & 1 deletion apps/server/src/orchestration/Layers/ProviderCommandReactor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@ import {
ProviderDriverKind,
ProviderInstanceId,
ProviderSetupError,
type ServerSettings,
} from "@t3tools/contracts";
import { createModelSelection } from "@t3tools/shared/model";
import type { DeepPartial } from "@t3tools/shared/Struct";
import {
ApprovalRequestId,
CommandId,
Expand Down Expand Up @@ -176,6 +178,7 @@ describe("ProviderCommandReactor", () => {
readonly unreadableHistory?: boolean;
readonly titleRegenerationCompletionDispatchFailures?: number;
readonly titleRegenerationBeforeStart?: "one" | "two";
readonly serverSettingsOverrides?: DeepPartial<ServerSettings>;
readonly serverActivation?: Effect.Effect<void>;
readonly beforeReadySessionDispatch?: () => Effect.Effect<void>;
readonly beforeTurnStartDispatch?: () => Effect.Effect<void>;
Expand Down Expand Up @@ -490,7 +493,7 @@ describe("ProviderCommandReactor", () => {
generateThreadTitle,
}),
),
Layer.provideMerge(ServerSettingsService.layerTest()),
Layer.provideMerge(ServerSettingsService.layerTest(input?.serverSettingsOverrides ?? {})),
Layer.provideMerge(SqlitePersistenceMemory),
Layer.provideMerge(ServerConfig.layerTest(process.cwd(), baseDir)),
Layer.provideMerge(NodeServices.layer),
Expand Down Expand Up @@ -1849,6 +1852,236 @@ describe("ProviderCommandReactor", () => {
expect(thread?.titleRegeneration).toBeNull();
});

it("generates a first-turn title when the setting is left at its default", async () => {
const now = "2026-01-01T00:00:00.000Z";
const seededTitle = "Please investigate reconnect failures after restar...";
const harness = await createHarness({ initialTitle: seededTitle });
harness.generateThreadTitle.mockReturnValue(Effect.succeed({ title: "Generated title" }));

await harness.runEffect(
harness.engine.dispatch({
type: "thread.turn.start",
commandId: CommandId.make("cmd-turn-start-title-default"),
threadId: ThreadId.make("thread-1"),
message: {
messageId: asMessageId("user-message-title-default"),
role: "user",
text: "Please investigate reconnect failures after restarting the session.",
attachments: [],
},
titleSeed: seededTitle,
interactionMode: DEFAULT_PROVIDER_INTERACTION_MODE,
runtimeMode: "approval-required",
createdAt: now,
}),
);

await waitFor(() => harness.generateThreadTitle.mock.calls.length === 1);
await harness.drain();

const thread = (await harness.readModel()).threads.find(
(entry) => entry.id === ThreadId.make("thread-1"),
);
expect(thread?.title).toBe("Generated title");
});

it("keeps the deterministic first-prompt title when AI title generation is disabled", async () => {
const now = "2026-01-01T00:00:00.000Z";
const seededTitle = "Please investigate reconnect failures after restar...";
const harness = await createHarness({
initialTitle: seededTitle,
serverSettingsOverrides: { generateThreadTitles: false },
});
harness.generateThreadTitle.mockReturnValue(Effect.succeed({ title: "Generated title" }));

await harness.runEffect(
harness.engine.dispatch({
type: "thread.turn.start",
commandId: CommandId.make("cmd-turn-start-title-disabled"),
threadId: ThreadId.make("thread-1"),
message: {
messageId: asMessageId("user-message-title-disabled"),
role: "user",
text: "Please investigate reconnect failures after restarting the session.",
attachments: [],
},
titleSeed: seededTitle,
interactionMode: DEFAULT_PROVIDER_INTERACTION_MODE,
runtimeMode: "approval-required",
createdAt: now,
}),
);

await harness.drain();

expect(harness.generateThreadTitle).not.toHaveBeenCalled();
const thread = (await harness.readModel()).threads.find(
(entry) => entry.id === ThreadId.make("thread-1"),
);
expect(thread?.title).toBe(seededTitle);
});

it("clears manual title regeneration without generating when disabled", async () => {
const now = "2026-01-01T00:00:00.000Z";
const harness = await createHarness({
serverSettingsOverrides: { generateThreadTitles: false },
});
harness.generateThreadTitle.mockReturnValue(
Effect.succeed({ title: "Resolve stale reconnect state" }),
);

await harness.runEffect(
harness.engine.dispatch({
type: "thread.meta.update",
commandId: CommandId.make("cmd-thread-title-existing-disabled"),
threadId: ThreadId.make("thread-1"),
title: "Investigate reconnect regressions",
}),
);
await harness.runEffect(
harness.engine.dispatch({
type: "thread.turn.start",
commandId: CommandId.make("cmd-turn-start-before-disabled-regeneration"),
threadId: ThreadId.make("thread-1"),
message: {
messageId: asMessageId("user-message-before-disabled-regeneration"),
role: "user",
text: "Please investigate reconnect regressions after restarting the session.",
attachments: [],
},
interactionMode: DEFAULT_PROVIDER_INTERACTION_MODE,
runtimeMode: "approval-required",
createdAt: now,
}),
);
await harness.runEffect(
harness.engine.dispatch({
type: "thread.message.assistant.delta",
commandId: CommandId.make("cmd-assistant-before-disabled-regeneration"),
threadId: ThreadId.make("thread-1"),
messageId: asMessageId("assistant-message-before-disabled-regeneration"),
delta: "The remaining issue is stale reconnect state.",
createdAt: "2026-01-01T00:00:01.000Z",
}),
);
await harness.runEffect(
harness.engine.dispatch({
type: "thread.message.assistant.complete",
commandId: CommandId.make("cmd-assistant-complete-before-disabled-regeneration"),
threadId: ThreadId.make("thread-1"),
messageId: asMessageId("assistant-message-before-disabled-regeneration"),
createdAt: "2026-01-01T00:00:02.000Z",
}),
);
await harness.runEffect(
harness.engine.dispatch({
type: "thread.meta.update",
commandId: CommandId.make("cmd-thread-title-regenerate-disabled"),
threadId: ThreadId.make("thread-1"),
regenerateTitle: true,
}),
);

await harness.drain();

expect(harness.generateThreadTitle).not.toHaveBeenCalled();
const thread = (await harness.readModel()).threads.find(
(entry) => entry.id === ThreadId.make("thread-1"),
);
expect(thread?.title).toBe("Investigate reconnect regressions");
expect(thread?.titleRegeneration).toBeNull();
});

it("does not refine a vague generated title when disabled", async () => {
const harness = await createHarness({
serverSettingsOverrides: { generateThreadTitles: false },
});
const threadId = ThreadId.make("thread-1");
const turnId = TurnId.make("title-first-turn-disabled");
const createdAt = "2026-01-01T00:00:01.000Z";
harness.generateThreadTitle.mockReturnValue(Effect.succeed({ title: "Fix QR pairing expiry" }));

await harness.runEffect(
harness.engine.dispatch({
type: "thread.turn.start",
commandId: CommandId.make("title-turn-disabled"),
threadId,
message: {
messageId: MessageId.make("title-user-disabled"),
role: "user",
text: "Fix this",
attachments: [],
},
interactionMode: DEFAULT_PROVIDER_INTERACTION_MODE,
runtimeMode: "approval-required",
createdAt,
}),
);
await harness.drain();
await harness.runEffect(
harness.engine.dispatch({
type: "thread.title.generate.complete",
commandId: CommandId.make("initial-title-disabled"),
threadId,
expectedTitle: "Thread",
expectedVersion: null,
title: "Investigate issue",
needsRefinement: true,
}),
);
await harness.runEffect(
harness.engine.dispatch({
type: "thread.session.set",
commandId: CommandId.make("title-running-disabled"),
threadId,
createdAt,
session: {
threadId,
status: "running",
providerName: "codex",
runtimeMode: "approval-required",
activeTurnId: turnId,
lastError: null,
updatedAt: createdAt,
},
}),
);
await harness.runEffect(
harness.engine.dispatch({
type: "thread.message.assistant.delta",
commandId: CommandId.make("title-answer-disabled"),
threadId,
messageId: MessageId.make("title-assistant-disabled"),
turnId,
delta: "The QR pairing token expires before the phone redeems it.",
createdAt,
}),
);
await harness.runEffect(
harness.engine.dispatch({
type: "thread.session.set",
commandId: CommandId.make("title-ready-disabled"),
threadId,
createdAt,
session: {
threadId,
status: "ready",
providerName: "codex",
runtimeMode: "approval-required",
activeTurnId: null,
lastError: null,
updatedAt: createdAt,
},
}),
);

await harness.drain();

expect(harness.generateThreadTitle).not.toHaveBeenCalled();
const thread = (await harness.readModel()).threads.find((entry) => entry.id === threadId);
expect(thread?.title).toBe("Investigate issue");
});

it("pins the first user message when regeneration context is truncated", async () => {
const harness = await createHarness();
const now = "2026-01-01T00:00:00.000Z";
Expand Down
17 changes: 10 additions & 7 deletions apps/server/src/orchestration/Layers/ProviderCommandReactor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,9 +963,9 @@ const make = Effect.gen(function* () {
}) {
const attachments = input.attachments ?? [];
yield* Effect.gen(function* () {
const { textGenerationModelSelection: modelSelection } = yield* projectSettingsForThread(
input.threadId,
);
const { textGenerationModelSelection: modelSelection, generateThreadTitles } =
yield* projectSettingsForThread(input.threadId);
if (!generateThreadTitles) return;

const generated = yield* textGeneration
.generateThreadTitle({
Expand Down Expand Up @@ -1022,6 +1022,8 @@ const make = Effect.gen(function* () {
thread.session?.status !== "ready"
)
return;
const { generateThreadTitles } = yield* projectSettingsForThread(threadId);
if (!generateThreadTitles) return;
const detail = yield* resolveThreadDetail(threadId);
if (!detail || detail.messages.filter((message) => message.role === "user").length !== 1)
return;
Expand Down Expand Up @@ -1061,10 +1063,11 @@ const make = Effect.gen(function* () {
thread,
projects: project ? [project] : [],
}) ?? process.cwd();
const { textGenerationModelSelection: modelSelection } = resolveProjectSettings(
yield* serverSettingsService.getSettings,
thread.projectId,
).settings;
const { textGenerationModelSelection: modelSelection, generateThreadTitles } =
resolveProjectSettings(yield* serverSettingsService.getSettings, thread.projectId).settings;
if (!generateThreadTitles) {
return { _tag: "Completed", title: undefined } as const;
}
const generated = yield* textGeneration.generateThreadTitle({
cwd,
message,
Expand Down
Loading
Loading