Skip to content

Refactor JenkinsJobRunner to allow unit testing #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
null511 merged 1 commit into from
May 9, 2025
Merged

Refactor JenkinsJobRunner to allow unit testing #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Jenkins.Net/Utilities/JenkinsJobRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ namespace JenkinsNET.Utilities
/// </summary>
public class JenkinsJobRunner
{
public JenkinsClient Client {get;}
public IJenkinsClient Client {get;}
protected ProgressiveTextReader textReader;
protected bool isJobStarted;

Expand Down Expand Up @@ -91,7 +91,7 @@ public class JenkinsJobRunner
/// <summary>
/// Creates a new JobRunner using the provided Jenkins-Client.
/// </summary>
public JenkinsJobRunner(JenkinsClient client)
public JenkinsJobRunner(IJenkinsClient client)
{
this.Client = client ?? throw new ArgumentNullException(nameof(client));
}
Expand Down
4 changes: 2 additions & 2 deletions Jenkins.Net/Utilities/ProgressiveTextReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ namespace JenkinsNET.Utilities
/// </summary>
public class ProgressiveTextReader
{
private readonly JenkinsClient client;
private readonly IJenkinsClient client;
private readonly string jobName;
private readonly string buildNumber;
private int readPos;
Expand Down Expand Up @@ -46,7 +46,7 @@ public class ProgressiveTextReader
/// <param name="client">The Jenkins client to use for network operations.</param>
/// <param name="jobName">The name of the Jenkins Job.</param>
/// <param name="buildNumber">The build-number of the running Jenkins Job.</param>
public ProgressiveTextReader(JenkinsClient client, string jobName, string buildNumber)
public ProgressiveTextReader(IJenkinsClient client, string jobName, string buildNumber)
{
this.client = client ?? throw new ArgumentNullException(nameof(client));
this.jobName = jobName ?? throw new ArgumentNullException(nameof(jobName));
Expand Down