Skip to content

fix: remove duplicate loop - #8430

Merged
wraithgar merged 1 commit into
npm:latestfrom
G-Rath:patch-2
Jul 10, 2025
Merged

fix: remove duplicate loop#8430
wraithgar merged 1 commit into
npm:latestfrom
G-Rath:patch-2

Conversation

@G-Rath

@G-Rath G-Rath commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

This loop is the exact same as this.#idealTreePrune:

#idealTreePrune () {
for (const node of this.idealTree.inventory.values()) {
if (node.extraneous) {
node.parent = null
}
}
}

I'm 98% sure it's a left-over from a refactor that intended to encapsulate the logic so it can be reused elsewhere

References

@G-Rath
G-Rath requested a review from a team as a code owner July 10, 2025 20:16
@G-Rath G-Rath changed the title refactor: remove duplicate loop chore: remove duplicate loop Jul 10, 2025
@wraithgar wraithgar changed the title chore: remove duplicate loop fix: remove duplicate loop Jul 10, 2025
@wraithgar

Copy link
Copy Markdown
Contributor

Even worse it was part of a code cleanup that I apparently hit "paste" into somehow as I was doing it. Good catch.

#6393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants