Successful migration doesn't close connection

After a successful migration, the connection is not closed.

Change catch to finally:

efcore.pg/src/EFCore.PG/Migrations/Internal/NpgsqlMigrator.cs

Lines 83 to 91 in 3cbdba4

    
           _connection.Open(); 
        
           try 
        
           { 
        
               npgsqlConnection.ReloadTypes(); 
        
           } 
        
           catch 
        
           { 
        
               _connection.Close(); 
        
           }

and

efcore.pg/src/EFCore.PG/Migrations/Internal/NpgsqlMigrator.cs

Lines 126 to 134 in 3cbdba4

    
           await _connection.OpenAsync(cancellationToken).ConfigureAwait(false); 
        
           try 
        
           { 
        
               await npgsqlConnection.ReloadTypesAsync(cancellationToken).ConfigureAwait(false); 
        
           } 
        
           catch 
        
           { 
        
               await _connection.CloseAsync().ConfigureAwait(false); 
        
           }

Always close connection after reloading types in migration.

Always close connection after reloading types in migration. (#3465)

Navigation Menu

Repository navigation

Successful migration doesn't close connection #3464

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	_connection.Open();
	try
	{
	npgsqlConnection.ReloadTypes();
	}
	catch
	{
	_connection.Close();
	}

	await _connection.OpenAsync(cancellationToken).ConfigureAwait(false);
	try
	{
	await npgsqlConnection.ReloadTypesAsync(cancellationToken).ConfigureAwait(false);
	}
	catch
	{
	await _connection.CloseAsync().ConfigureAwait(false);
	}

Successful migration doesn't close connection #3464

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions