Skip to content

fix: some broken links at collaborator guide - #6426

Merged
ovflowd merged 3 commits into
nodejs:mainfrom
mahmudhmh:main
Mar 4, 2024
Merged

fix: some broken links at collaborator guide#6426
ovflowd merged 3 commits into
nodejs:mainfrom
mahmudhmh:main

Conversation

@mahmudhmh

@mahmudhmh mahmudhmh commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

there were some broken links and fixed them in the collaborator guide @ovflowd @AugustinMauroy

@mahmudhmh
mahmudhmh requested a review from a team as a code owner March 4, 2024 08:36
@vercel

vercel Bot commented Mar 4, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 4, 2024 4:31pm

@mahmudhmh mahmudhmh changed the title Main fix: some broken links at collaborator guide Mar 4, 2024
Comment thread COLLABORATOR_GUIDE.md Outdated
@AugustinMauroy

Copy link
Copy Markdown
Member

Other point you are not obligated to ping us we are already ping with the code owner

Comment thread COLLABORATOR_GUIDE.md Outdated

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is changing links that aren't broken.

@mahmudhmh

Copy link
Copy Markdown
Contributor Author

I've added the next-intl definition referenced with the npm link

[`next-intl`]: https://www.npmjs.com/package/next-intl

@bmuenzenmeyer

Copy link
Copy Markdown
Contributor

now the remaining react-intl references should be replaced with your new next-intl reference, right?

@mahmudhmh

Copy link
Copy Markdown
Contributor Author

now the remaining react-intl references should be replaced with your new next-intl reference, right?

no, I'm just adding the reference to the next-intl one, not the react-intl which was already working

@ovflowd

ovflowd commented Mar 4, 2024

Copy link
Copy Markdown
Member

Thanks for the first-time contribution! And for making updates to the requested changes!

@github-actions

github-actions Bot commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 90 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 92 🟢 100 🟢 92 🔗

@ovflowd

ovflowd commented Mar 4, 2024

Copy link
Copy Markdown
Member

I'm fast-tracking this as a simple fix.

@ovflowd
ovflowd enabled auto-merge March 4, 2024 20:05
@github-actions

github-actions Bot commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
80.18% (433/540) 79.65% (137/172) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.71s ⏱️

@ovflowd
ovflowd added this pull request to the merge queue Mar 4, 2024
@mahmudhmh

Copy link
Copy Markdown
Contributor Author

Thanks for the first-time contribution! And for making updates to the requested changes!

Thank you sm, and sorry for the conflict at the beginning

Merged via the queue into nodejs:main with commit 5380385 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants