Skip to content

test: deflake test-run-watch-cwd-isolation-none-* - #66035

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:test-watch-flakes
Sep 18, 2026
Merged

aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:test-watch-flakes

Conversation

@aduh95

@aduh95 aduh95 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Before this PR, on my machine:

$ tools/test.py --repeat 999 test/test-runner/test-run-watch-cwd-isolation-none.mjs test/test-runner/test-run-watch-cwd-isolation-none-argv.mjs
[…]
[00:57|% 100|+ 1364|- 634]: Done
[…]

With this PR:

$ tools/test.py --repeat 999 test/test-runner/test-run-watch-cwd-isolation-none.mjs test/test-runner/test-run-watch-cwd-isolation-none-argv.mjs
[01:03|% 100|+ 1998|-   0]: Done                                          

All tests passed.

Refs: #66056

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 15, 2026
@aduh95 aduh95 changed the title test: fix test-run-watch flakiness test: deflake test-run-watch-cwd-isolation-none-* Sep 15, 2026
@panva panva added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Sep 15, 2026
@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (8566220) to head (c5f7178).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66035      +/-   ##
==========================================
+ Coverage   90.27%   90.28%   +0.01%     
==========================================
  Files         790      790              
  Lines      271642   271642              
  Branches    51840    51843       +3     
==========================================
+ Hits       245214   245252      +38     
+ Misses      16939    16887      -52     
- Partials     9489     9503      +14     

see 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva

panva commented Sep 15, 2026

Copy link
Copy Markdown
Member

Drop the test/common/watch.js changes and it should be good to go. Plus an update to test/test-runner/test-runner.status is due

@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 15, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95

aduh95 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author
00:05:07.232 not ok 1395 test-runner/test-run-watch-cwd-isolation-none
00:05:07.232   ---
00:05:07.232   duration_ms: 729.99900
00:05:07.233   severity: fail
00:05:07.233   exitcode: 1
00:05:07.233   stack: |-
00:05:07.233   ...

Humpf failure on Windows

@aduh95

aduh95 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

I don't have a win-arm64 machine, and I wasn't able to reproduce to x86:

> python.exe .\tools\test.py --shell=../v27.0.0-nightly2026090729667e046b/win-x64/node.exe --repeat 9999 test/test-runner/test-run-watch-cwd-isolation-none.mjs test/test-runner/test-run-watch-cwd-isolation-none-argv.mjs
[17:27|% 100|+ 19998|-   0]: Done

I guess I'll mark it as flaky on that platform and move on

@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 16, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 16, 2026
@github-actions github-actions Bot removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has conflicts with its base branch, removing the author ready label.
Please rebase your branch onto the latest base branch, resolve the conflicts locally, and force-push.
Afterwards the pull request needs a fresh collaborator approval, and a collaborator will add the label back once it is author ready again.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95
aduh95 merged commit ebef774 into nodejs:main Sep 18, 2026
61 of 64 checks passed
@aduh95

aduh95 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

Landed in ebef774

@aduh95
aduh95 deleted the test-watch-flakes branch September 18, 2026 15:15
aduh95 added a commit that referenced this pull request Sep 18, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #66035
Refs: #66056
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants