stream: destroy Duplex.from async function on early return - #65963
Merged
nodejs-github-bot merged 1 commit intoSep 18, 2026
Merged
Conversation
When an AsyncFunction passed to Duplex.from() resolves without consuming its input, tear down the duplex so pipeline() can finish and destroy the upstream readable. Fixes: nodejs#55077 Assisted-by: Cursor Signed-off-by: Aman Chadha <79802170+ac-mmi@users.noreply.github.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65963 +/- ##
==========================================
- Coverage 90.17% 90.16% -0.02%
==========================================
Files 771 771
Lines 265489 265498 +9
Branches 50471 50483 +12
==========================================
- Hits 239405 239377 -28
- Misses 17042 17051 +9
- Partials 9042 9070 +28
🚀 New features to boost your workflow:
|
meixg
approved these changes
Sep 11, 2026
meixg
added
the
request-ci
github-actions
Bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
panva
added
the
author ready
Collaborator
Contributor
Author
|
@jasnell I noticed the Jenkins CI run has 4 failing checks, but I don't have access to the Jenkins logs. Could you please take a look and let me know whether the failures are related to this change or infrastructure/flakiness? Thanks! |
Collaborator
inoway46
added
the
commit-queue
Collaborator
|
Landed in 0bf9e9f |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Sep 18, 2026
When an AsyncFunction passed to Duplex.from() resolves without consuming its input, tear down the duplex so pipeline() can finish and destroy the upstream readable. Fixes: #55077 Assisted-by: Cursor Signed-off-by: Aman Chadha <79802170+ac-mmi@users.noreply.github.com> PR-URL: #65963 Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
Duplex.from(asyncFn)is given an AsyncFunction that returns without consuming its async-iterable input, the duplex can remain unfinished, causingpipeline()to hang and preventing the upstream Readable from being destroyed.Track whether writable
final()has started. If the AsyncFunction resolves successfully beforefinal(), destroy the duplex so that pipeline cleanup can propagate upstream.The change is scoped to the AsyncFunction path and does not modify the shared
fromAsyncGen()/ async-generator transform behavior.Fixes: #55077