Conversation
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65928 +/- ##
==========================================
+ Coverage 90.17% 90.18% +0.01%
==========================================
Files 771 771
Lines 265470 265470
Branches 50463 50460 -3
==========================================
+ Hits 239383 239412 +29
+ Misses 17055 17003 -52
- Partials 9032 9055 +23 🚀 New features to boost your workflow:
|
Collaborator
lpinca
approved these changes
Sep 9, 2026
jasnell
force-pushed
the
jasnell/sequential-test-fixes
branch
from
September 10, 2026 20:56
e52279d to
9f71ba0
Compare
Make a couple of sequential tests clean up eagerly to reduce runtime. Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
jasnell
force-pushed
the
jasnell/sequential-test-fixes
branch
from
September 10, 2026 22:38
9f71ba0 to
6005dd5
Compare
panva
approved these changes
Sep 13, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
jasnell
added a commit
that referenced
this pull request
Sep 13, 2026
Make a couple of sequential tests clean up eagerly to reduce runtime. Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode PR-URL: #65928 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Member
Author
|
Landed in 577b9c2 |
aduh95
pushed a commit
that referenced
this pull request
Sep 16, 2026
Make a couple of sequential tests clean up eagerly to reduce runtime. Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode PR-URL: #65928 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make a couple of sequential tests clean up eagerly to reduce runtime. Potentially saves in the range of 5-12 seconds per run on some CI jobs.