Skip to content

http: cache maxHeaderPairs per header section - #64988

Open
GetThatCookie wants to merge 1 commit into
nodejs:mainfrom
GetThatCookie:pr64980_parser
Open

http: cache maxHeaderPairs per header section#64988
GetThatCookie wants to merge 1 commit into
nodejs:mainfrom
GetThatCookie:pr64980_parser

Conversation

@GetThatCookie

Copy link
Copy Markdown

This PR is one of four focused changes split out of #64980 following review
feedback.

The full context, rationale, related work, benchmarks, and validation details
are documented there.

The AI-assistance disclosure in #64980 applies to this split PR as well.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net
  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. needs-ci PRs that need a full CI run. labels Aug 3, 2026
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.32%. Comparing base (f00fb75) to head (ef24255).
⚠️ Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64988      +/-   ##
==========================================
+ Coverage   90.27%   90.32%   +0.04%     
==========================================
  Files         762      759       -3     
  Lines      247534   247636     +102     
  Branches    46694    46693       -1     
==========================================
+ Hits       223457   223665     +208     
+ Misses      15529    15454      -75     
+ Partials     8548     8517      -31     
Files with missing lines Coverage Δ
src/node_http_parser.cc 85.62% <100.00%> (+0.64%) ⬆️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pimterry pimterry added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 4, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Signed-off-by: GetThatCookie <NimmenKeks@gmx.de>
@pimterry

pimterry commented Aug 5, 2026

Copy link
Copy Markdown
Member

@GetThatCookie why the force push? Can you explain why the implementation has changed and that test code was dropped? It's helpful to provide context for reviewers when substantially changing a PR like this.

At a glance, it looks like this new code is just doing the same thing but in a more fragile less clear way, and with less testing? Presumably I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants