Skip to content

quic: validate :path in sendHeaders - #64936

Closed
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:quicpath
Closed

quic: validate :path in sendHeaders#64936
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:quicpath

Conversation

@Archkon

@Archkon Archkon commented Aug 1, 2026

Copy link
Copy Markdown

Fixes: #64924

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Aug 1, 2026
@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (a876a12) to head (7360e6a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #64936   +/-   ##
=======================================
  Coverage   90.32%   90.33%           
=======================================
  Files         759      759           
  Lines      248325   248325           
  Branches    46861    46867    +6     
=======================================
+ Hits       224303   224313   +10     
+ Misses      15467    15452   -15     
- Partials     8555     8560    +5     

see 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread lib/internal/quic/quic.js Outdated
Comment thread lib/internal/quic/quic.js Outdated
@Archkon

This comment was marked as spam.

@jasnell

jasnell commented Aug 8, 2026

Copy link
Copy Markdown
Member

@Archkon ... yes, http-specific validation belongs in the http-specific application.

Reject invalid :path values before passing headers to nghttp3.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@jasnell
jasnell requested a review from pimterry August 8, 2026 21:25
@jasnell

jasnell commented Aug 8, 2026

Copy link
Copy Markdown
Member

/cc @nodejs/quic for reviews

@aduh95 aduh95 closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quic: sendHeaders with non conforming path

5 participants