Skip to content

doc: improve TestContext hook descriptions - #64899

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Rawal27:docs-testcontext-hook-descriptions
Aug 3, 2026
Merged

doc: improve TestContext hook descriptions#64899
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Rawal27:docs-testcontext-hook-descriptions

Conversation

@Rawal27

@Rawal27 Rawal27 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Improve the wording of the TestContext hook API descriptions for consistency and readability.

Changes

  • Update the descriptions for:
    • context.before()
    • context.beforeEach()
    • context.after()
    • context.afterEach()
  • Use consistent phrasing across all four hook descriptions.
  • No behavioral or API changes.

Motivation

The existing descriptions use slightly different wording and phrasing. This change makes the documentation more consistent while preserving the existing semantics.

Signed-off-by: Rawal27 <obviouslykamal@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Aug 1, 2026
@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 2, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 3, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 7e43982 into nodejs:main Aug 3, 2026
31 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 7e43982

aduh95 pushed a commit that referenced this pull request Aug 3, 2026
Signed-off-by: Rawal27 <obviouslykamal@gmail.com>
PR-URL: #64899
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Aug 4, 2026
Signed-off-by: Rawal27 <obviouslykamal@gmail.com>
PR-URL: #64899
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Aug 4, 2026
Signed-off-by: Rawal27 <obviouslykamal@gmail.com>
PR-URL: #64899
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Aug 5, 2026
Signed-off-by: Rawal27 <obviouslykamal@gmail.com>
PR-URL: #64899
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
Signed-off-by: Rawal27 <obviouslykamal@gmail.com>
PR-URL: #64899
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants