doc: use ffi.suffix for library paths in examples - #64805
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
Replace hardcoded .so library paths with ffi.suffix in the FFI documentation examples. Signed-off-by: Junsoo Ha <junsoo2018@naver.com>
ShogunPanda
approved these changes
Jul 28, 2026
avivkeller
approved these changes
Jul 28, 2026
trivikr
approved these changes
Jul 28, 2026
trivikr
added
commit-queue
lpinca
approved these changes
Jul 28, 2026
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in cacd7a2 |
aduh95
pushed a commit
that referenced
this pull request
Aug 3, 2026
Replace hardcoded .so library paths with ffi.suffix in the FFI documentation examples. Signed-off-by: Junsoo Ha <junsoo2018@naver.com> PR-URL: #64805 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 4, 2026
Replace hardcoded .so library paths with ffi.suffix in the FFI documentation examples. Signed-off-by: Junsoo Ha <junsoo2018@naver.com> PR-URL: #64805 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 5, 2026
Replace hardcoded .so library paths with ffi.suffix in the FFI documentation examples. Signed-off-by: Junsoo Ha <junsoo2018@naver.com> PR-URL: #64805 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded
.solibrary paths with ffi.suffix in the FFI documentation examples.This makes the examples portable across Linux, macOS, and Windows without requiring users to manually change the shared library extension.