test_runner: convert to uint during deserialization - #64706
Merged
Conversation
Signed-off-by: Aviv Keller <me@aviv.sh>
avivkeller
added
the
test_runner
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64706 +/- ##
==========================================
- Coverage 90.14% 90.12% -0.02%
==========================================
Files 741 741
Lines 242241 242241
Branches 45617 45627 +10
==========================================
- Hits 218366 218318 -48
- Misses 15361 15394 +33
- Partials 8514 8529 +15
🚀 New features to boost your workflow:
|
MoLow
approved these changes
Jul 24, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
avivkeller
added
the
author ready
atlowChemi
approved these changes
Jul 26, 2026
atlowChemi
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 1ba3ce4 |
NicolaiDolmer
added a commit
to NicolaiDolmer/CyclingZone
that referenced
this pull request
Aug 3, 2026
…ation (#3172) (#3222) * fix(ci): isolate economyEngine.test.js to stop worker-IPC flake backend/lib/economyEngine.test.js is by far the largest backend test file (100+ tests, 6500+ lines, ~250KB) and its per-worker result payload appears large enough to trip a known Node test-runner bug (nodejs/node#64061, root-caused and fixed upstream in nodejs/node#64706, merged 2026-07-26 but not yet in our pinned Node 24.x line) when many other test-file workers stream results back to the parent process concurrently. Isolated runs were always 102/102 (now 103/103) green; the flake only ever showed up in the full suite (#3169-CI, #3171-CI). Add backend/scripts/run-tests.js: runs economyEngine.test.js alone first, then every other backend test file exactly as before (same flags, same default concurrency) via explicit relative file paths so the two passes never overlap. Wire both npm test (backend/package.json - the one permitted package.json edit) and scripts/verify-local.ps1 (which called `node --test` directly, bypassing npm entirely) through this script so CI and local pre-push runs get the same protection. No dependency or lockfile changes. Verified with 5 consecutive `npm test` runs locally (103/103 + 4773/4773 every time, exit 0). Refs #3172 Co-Authored-By: Claude <noreply@anthropic.com> * docs(learnings): postmortem for economyEngine.test.js worker-IPC flake Refs #3172 Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Nicolai Dolmer <213100469+NicolaiDolmer@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 3, 2026
Signed-off-by: Aviv Keller <me@aviv.sh> PR-URL: #64706 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
Aug 4, 2026
Signed-off-by: Aviv Keller <me@aviv.sh> PR-URL: #64706 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Signed-off-by: Aviv Keller <me@aviv.sh> PR-URL: #64706 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64061 by adding
>>> 0(to convert to a uint) in our test runner'sprocessRawBuffer, similarly to how we do inchild_process.cc @nodejs/test_runner @MoLow