Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/_http_server.js
Original file line number Diff line number Diff line change
Expand Up @@ -739,11 +739,18 @@ assignFunctionName(EE.captureRejectionSymbol, function(err, event, ...args) {
});

function checkConnections() {
if (this.headersTimeout === 0 && this.requestTimeout === 0) {
const headersTimeout =
NumberIsFinite(this.headersTimeout) && this.headersTimeout >= 0 ?
this.headersTimeout : 0;
const requestTimeout =
NumberIsFinite(this.requestTimeout) && this.requestTimeout >= 0 ?
this.requestTimeout : 0;

if (headersTimeout === 0 && requestTimeout === 0) {
return;
}

const expired = this[kConnections].expired(this.headersTimeout, this.requestTimeout);
const expired = this[kConnections].expired(headersTimeout, requestTimeout);

for (let i = 0; i < expired.length; i++) {
const socket = expired[i].socket;
Expand Down
19 changes: 19 additions & 0 deletions test/parallel/test-http-server-invalid-headers-timeout-no-abort.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
'use strict';

const common = require('../common');
const assert = require('assert');
const { createServer } = require('http');

const server = createServer({
connectionsCheckingInterval: 1,
}, common.mustNotCall());

// Invalid headersTimeout should not crash the server
server.headersTimeout = 'im-not-a-number';
assert.strictEqual(server.headersTimeout, 'im-not-a-number');

server.listen(0, '127.0.0.1', common.mustCall(() => {
setTimeout(common.mustCall(() => {
server.close(common.mustCall());
}), common.platformTimeout(50));
}));
Loading