buffer: handle detached ArrayBuffer views#64504
Conversation
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64504 +/- ##
==========================================
- Coverage 90.14% 90.13% -0.01%
==========================================
Files 741 741
Lines 242076 242051 -25
Branches 45558 45543 -15
==========================================
- Hits 218216 218184 -32
- Misses 15385 15398 +13
+ Partials 8475 8469 -6
🚀 New features to boost your workflow:
|
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
As mentioned in the thread, I'd actually rather we went the other direction to treat detached just as zero-length with these.
@jasnell |
|
@jasnell sorry to ping you again but I'm working on multiple pr now so would you review this code and see whether merge this ? Or to tell me something to change or modify ? |
Treat detached ArrayBuffers and Buffer or TypedArray views backed by them as zero-length inputs in buffer.isUtf8() and buffer.isAscii(). Both functions now return true for these inputs, consistent with other empty inputs. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
|
@jasnell Sorry to keep ping and may I ask you to review this again ? |
|
@Archkon ... please keep in mind that folks in the project are volunteers that are often quite busy. Pinging every couple of days for review is a bit rude. An occasional ping once in a while is fine but three pings within a week is excessive. |
Sorry I just think you are active maintainer and fear that you would ignore this one.I would bear that in my mind with more patience |
3 participants
Fixes: #64503