Skip to content

module: implement Symbol.dispose in ModuleHooks - #63928

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
remcohaszing:module-register-hooks-disposable
Jul 26, 2026
Merged

module: implement Symbol.dispose in ModuleHooks#63928
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
remcohaszing:module-register-hooks-disposable

Conversation

@remcohaszing

@remcohaszing remcohaszing commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

This change implements the Symbol.dispose key in the ModuleHooks class as an alias for deregister. This makes registerHooks work with the using keyword.

Fixes: #63846

@nodejs-github-bot

nodejs-github-bot commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Jun 15, 2026
@remcohaszing remcohaszing changed the title module: import Symbol.dispose in ModuleHooks module: implement Symbol.dispose in ModuleHooks Jun 15, 2026
@remcohaszing
remcohaszing force-pushed the module-register-hooks-disposable branch from 5dd9b5d to 73e5743 Compare June 15, 2026 13:53
@remcohaszing
module: implement Symbol.dispose in ModuleHooks
c0c9ee7 
This change implements the `Symbol.dispose` key in the
`ModuleHooks` class as an alias for deregister. This makes
`registerHooks` work with the `using` keyword.

Fixes: nodejs#63846
Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
@remcohaszing
remcohaszing force-pushed the module-register-hooks-disposable branch from 73e5743 to c0c9ee7 Compare June 15, 2026 14:29
mcollina
mcollina approved these changes Jun 15, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Renegade334 Renegade334 added semver-minor PRs that contain new features and should be released in the next minor version. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 21, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74327/

aduh95
aduh95 reviewed Jun 21, 2026
View reviewed changes
Comment thread lib/internal/modules/customization_hooks.js Outdated
@remcohaszing @aduh95
Update lib/internal/modules/customization_hooks.js
b926f80 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Renegade334
Renegade334 approved these changes Jul 10, 2026
View reviewed changes
Comment thread doc/api/module.md
Comment on lines 244 to +248
* Returns: {Object} An object with the following property:
* `deregister()` {Function} Remove the registered hooks so that they are no
longer called. Hooks are otherwise retained for the lifetime of the running
process.
* `[Symbol.dispose]` {Function} The same as `deregister`.

@Renegade334 Renegade334 Jul 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This is probably at the stage where it would be best to document a non-directly-constructable ModuleHooks class with proper instance methods. Can be a follow-up though.

@Renegade334 Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 10, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 10, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74728/

@trivikr trivikr added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 26, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 26, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 2c4ea73 into nodejs:main Jul 26, 2026
73 of 74 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Landed in 2c4ea73

@remcohaszing
remcohaszing deleted the module-register-hooks-disposable branch July 26, 2026 07:13
aduh95 pushed a commit that referenced this pull request Aug 3, 2026
@remcohaszing @aduh95
module: implement Symbol.dispose in ModuleHooks
4c543fa 
This change implements the `Symbol.dispose` key in the
`ModuleHooks` class as an alias for deregister. This makes
`registerHooks` work with the `using` keyword.

Fixes: #63846
Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
PR-URL: #63928
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Jacob Smith <jacob@frende.me>
aduh95 pushed a commit that referenced this pull request Aug 4, 2026
@remcohaszing @aduh95
module: implement Symbol.dispose in ModuleHooks
11c2f9c 
This change implements the `Symbol.dispose` key in the
`ModuleHooks` class as an alias for deregister. This makes
`registerHooks` work with the `using` keyword.

Fixes: #63846
Signed-off-by: Remco Haszing <remcohaszing@gmail.com>
PR-URL: #63928
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Jacob Smith <jacob@frende.me>
@github-actions github-actions Bot mentioned this pull request Aug 4, 2026
Merged
nodejs-github-bot added a commit that referenced this pull request Aug 4, 2026
@nodejs-github-bot
2026-08-05, Version 26.7.0 (Current)
e4692ad 
Notable changes:

build:
  * (SEMVER-MINOR) perfetto-sdk (Chengzhong Wu) #64565
crypto:
  * (SEMVER-MINOR) support loading private keys through STORE loaders (Filip Skokan) #63949
  * update root certificates to NSS 3.125 (Node.js GitHub Bot) #64746
doc:
  * (SEMVER-MINOR) formalize fn/name as part of TestOptions API (Christopher Hiller) #64946
lib:
  * (SEMVER-MINOR) add perfetto support (Chengzhong Wu) #64565
module:
  * (SEMVER-MINOR) implement Symbol.dispose in ModuleHooks (Remco Haszing) #63928
net:
  * (SEMVER-MINOR) add experimental net/promises API (Ethan Arrowood) #63965
src:
  * (SEMVER-MINOR) add perfetto trace agent (Chengzhong Wu) #64565
  * (SEMVER-MINOR) rename legacy trace event headers (Chengzhong Wu) #64565
  * (SEMVER-MINOR) fix trace macro compatibility (Chengzhong Wu) #64565
test_runner:
  * (SEMVER-MINOR) add support for --test-coverage-include-all (avivkeller) #64830

PR-URL: #65027
aduh95 pushed a commit that referenced this pull request Aug 4, 2026
@nodejs-github-bot @aduh95
2026-08-05, Version 26.7.0 (Current)
6ed9d89 
Notable changes:

crypto:
  * (SEMVER-MINOR) support loading private keys through STORE loaders (Filip Skokan) #63949
  * update root certificates to NSS 3.125 (Node.js GitHub Bot) #64746
lib:
  * (SEMVER-MINOR) add perfetto support (Chengzhong Wu) #64565
module:
  * (SEMVER-MINOR) implement `Symbol.dispose` in ModuleHooks (Remco Haszing) #63928
net:
  * (SEMVER-MINOR) add experimental `node:net/promises` API (Ethan Arrowood) #63965
test_runner:
  * (SEMVER-MINOR) add support for `--test-coverage-include-all` (avivkeller) #64830

PR-URL: #65027
aduh95 added a commit that referenced this pull request Aug 5, 2026
@aduh95
2026-08-05, Version 26.7.0 (Current)
b4f23d3 
Notable changes:

crypto:
  * (SEMVER-MINOR) support loading private keys through STORE loaders (Filip Skokan) #63949
  * update root certificates to NSS 3.125 (Node.js GitHub Bot) #64746
lib:
  * (SEMVER-MINOR) add perfetto support (Chengzhong Wu) #64565
module:
  * (SEMVER-MINOR) implement `Symbol.dispose` in ModuleHooks (Remco Haszing) #63928
test_runner:
  * (SEMVER-MINOR) add support for `--test-coverage-include-all` (avivkeller) #64830

PR-URL: #65027
aduh95 added a commit that referenced this pull request Aug 5, 2026
@aduh95
2026-08-05, Version 26.7.0 (Current)
3f2fc8a 
Notable changes:

crypto:
  * (SEMVER-MINOR) support loading private keys through STORE loaders (Filip Skokan) #63949
  * update root certificates to NSS 3.125 (Node.js GitHub Bot) #64746
lib:
  * (SEMVER-MINOR) add perfetto support (Chengzhong Wu) #64565
module:
  * (SEMVER-MINOR) implement `Symbol.dispose` in ModuleHooks (Remco Haszing) #63928
test_runner:
  * (SEMVER-MINOR) add support for `--test-coverage-include-all` (avivkeller) #64830

PR-URL: #65027
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments
@mcollina mcollina mcollina approved these changes
@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes
@Renegade334 Renegade334 Renegade334 approved these changes
+1 more reviewer
@jsumners-nr jsumners-nr jsumners-nr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Symbol.dispose in registerHooks()

8 participants

@remcohaszing @nodejs-github-bot @mcollina @JakobJingleheimer @Renegade334 @aduh95 @jsumners-nr @trivikr