Skip to content

test: Migrate message error tests from Python to JS - #49738

Open
akhateeb22 wants to merge 3 commits into
nodejs:mainfrom
akhateeb22:actions/migrate-tests
Open

test: Migrate message error tests from Python to JS#49738
akhateeb22 wants to merge 3 commits into
nodejs:mainfrom
akhateeb22:actions/migrate-tests

Conversation

@akhateeb22

@akhateeb22 akhateeb22 commented Sep 20, 2023

Copy link
Copy Markdown

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 20, 2023
@akhateeb22 akhateeb22 mentioned this pull request Sep 20, 2023
Closed
MoLow
MoLow reviewed Sep 20, 2023
View reviewed changes
Comment thread test/parallel/test-output-assert.mjs Outdated
MoLow
MoLow reviewed Sep 20, 2023
View reviewed changes

@MoLow MoLow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor fix needed

@akhateeb22

akhateeb22 commented Sep 20, 2023

Copy link
Copy Markdown
Author

@MoLow, Committed, Thank you

@MoLow
MoLow requested a review from atlowChemi September 20, 2023 20:48
@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 20, 2023
@akhateeb22
akhateeb22 force-pushed the actions/migrate-tests branch from 2a47489 to 6e8d588 Compare September 20, 2023 20:56
@akhateeb22

akhateeb22 commented Sep 20, 2023

Copy link
Copy Markdown
Author

@MoLow Hello, Thanks for reviewing, I committed some changes

atlowChemi
atlowChemi reviewed Sep 20, 2023
View reviewed changes
Comment thread package-lock.json Outdated
atlowChemi
atlowChemi reviewed Sep 20, 2023
View reviewed changes
Comment thread test/parallel/test-output-assert.mjs Outdated
atlowChemi
atlowChemi reviewed Sep 20, 2023
View reviewed changes
Comment thread test/fixtures/assert/assert_throws_stack.snapshot
Comment on lines -22 to -25
at assert.throws.bar (*assert_throws_stack.js:*)
at getActual (node:assert:*)
at Function.throws (node:assert:*)
at Object.<anonymous> (*assert_throws_stack.js:*:*)

@atlowChemi atlowChemi Sep 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the test checking exactly for this stack?

@akhateeb22 akhateeb22 Sep 21, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test should check for it exactly ?, current test generates:

  at * {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: Error: foo
      at *
      at *
      at *
      at *
      at *
      at *
      at *
      at *
      at *
      at node:internal*main*run_main_module**,
  expected: { bar: true },
  operator: 'throws'
}

@MoLow MoLow Sep 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the original PR adding this test: #27243
@BridgeAR is this test intended to snapshot the entire stack trace? is this change ok?

@akhateeb22 akhateeb22 Sep 22, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea or suggestions to close this PR ?

@MoLow MoLow Sep 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add another trasnform function to make this snapshot similar to the original one?

@aduh95

aduh95 commented May 11, 2024

Copy link
Copy Markdown
Contributor

This needs a rebase to solve the git conflicts.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

@github-actions github-actions Bot added the stale label Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLow MoLow MoLow approved these changes
@atlowChemi atlowChemi atlowChemi left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. stale test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@akhateeb22 @aduh95 @MoLow @atlowChemi @nodejs-github-bot