Skip to content

test_runner: export describe and it - #43420

Closed
MoLow wants to merge 24 commits into
nodejs:mainfrom
MoLow:test-runner-describe-it
Closed

test_runner: export describe and it#43420
MoLow wants to merge 24 commits into
nodejs:mainfrom
MoLow:test-runner-describe-it

Conversation

@MoLow

@MoLow MoLow commented Jun 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Refs: #43415

also, once #43403 is handled - it can probably be a good idea to implement/export a top-level implementation of before, beforeEach, after, afterEach where the parent test is found using executionAsyncId - the same way it is done in this PR

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. test_runner Issues and PRs related to the test runner subsystem. labels Jun 14, 2022
@MoLow MoLow changed the title test_runner: expose describe and it test_runner: export describe and it Jun 14, 2022
@MoLow

MoLow commented Jun 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

I would love to recieve initial feedback, before I start working on tests and documentation
CC. @benjamingr

@benjamingr

benjamingr commented Jun 14, 2022

Copy link
Copy Markdown
Member

Initial feedback is positive :) @nodejs/test_runner

jasnell
jasnell reviewed Jun 14, 2022
View reviewed changes
Comment thread lib/internal/test_runner/harness.js Outdated
@MoLow

MoLow commented Jun 14, 2022

Copy link
Copy Markdown
Member Author

cc @Linkgoron

@MoLow
MoLow force-pushed the test-runner-describe-it branch from e9ea260 to 6a8249e Compare June 14, 2022 19:24
@MoLow

MoLow commented Jun 15, 2022

Copy link
Copy Markdown
Member Author

@cjihrig can you please take a look?

@MoLow
MoLow force-pushed the test-runner-describe-it branch from 6a8249e to 561565d Compare June 15, 2022 13:38
ljharb
ljharb reviewed Jun 16, 2022
View reviewed changes
Comment thread lib/internal/test_runner/harness.js Outdated
Comment thread lib/internal/test_runner/harness.js Outdated
Comment thread lib/internal/test_runner/test.js Outdated
Comment thread lib/internal/test_runner/test.js Outdated
Comment thread lib/internal/test_runner/test.js Outdated
aduh95
aduh95 reviewed Jun 17, 2022
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would need to also update the docs.

Comment thread lib/internal/test_runner/harness.js Outdated
Comment thread lib/internal/test_runner/test.js Outdated
Comment thread lib/internal/test_runner/test.js Outdated
Comment thread lib/internal/test_runner/utils.js Outdated
@MoLow

MoLow commented Jun 19, 2022

Copy link
Copy Markdown
Member Author

@benjamingr AFAIK this pr is ready for review and landing, if you can please review and ping whom you think might be relevant

@MoLow MoLow mentioned this pull request Jun 19, 2022
Closed
@MoLow
MoLow requested a review from ljharb June 19, 2022 12:17
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44732/

@Linkgoron Linkgoron added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 26, 2022
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 26, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44862/

@benjamingr

benjamingr commented Jun 26, 2022

Copy link
Copy Markdown
Member

@nodejs/build can someone with access to the build machines take a look at the failure?

aduh95
aduh95 reviewed Jun 26, 2022
View reviewed changes
Comment thread doc/api/test.md Outdated
Comment thread doc/api/test.md Outdated
Comment thread doc/api/test.md Outdated
Comment thread doc/api/test.md Outdated
Comment thread doc/api/test.md Outdated
Comment thread doc/api/test.md Outdated
Comment thread lib/internal/test_runner/harness.js Outdated
Comment thread lib/internal/test_runner/test.js Outdated
Comment thread doc/api/test.md Outdated
Comment thread doc/api/test.md Outdated
@MoLow

MoLow commented Jun 26, 2022

Copy link
Copy Markdown
Member Author

@nodejs/build can someone with access to the build machines take a look at the failure?

this seems to be broken for a while https://ci.nodejs.org/job/node-cross-compile/

@richardlau richardlau mentioned this pull request Jun 27, 2022
Closed
@F3n67u

F3n67u commented Jun 27, 2022

Copy link
Copy Markdown
Contributor

FYI，@richardlau is investigating the node-cross-compile failure. I created a issue for this: nodejs/build#2977

@github-actions github-actions Bot mentioned this pull request Jun 28, 2022
Open
32 tasks
@nodejs-github-bot

nodejs-github-bot commented Jun 28, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44930/

@nodejs-github-bot

nodejs-github-bot commented Jun 28, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44933/

@github-actions github-actions Bot mentioned this pull request Jun 29, 2022
Open
23 tasks
@nodejs-github-bot

nodejs-github-bot commented Jun 29, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44952/

@benjamingr benjamingr added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 29, 2022
benjamingr pushed a commit that referenced this pull request Jun 29, 2022
@MoLow @benjamingr
test_runner: expose describe and it
e2225ba 
PR-URL: #43420
Refs: #43415
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@benjamingr

benjamingr commented Jun 29, 2022

Copy link
Copy Markdown
Member

Landed in e2225ba 🎉

@benjamingr benjamingr closed this Jun 29, 2022
@MoLow
MoLow deleted the test-runner-describe-it branch July 5, 2022 11:37
aduh95 pushed a commit to aduh95/node-core-test that referenced this pull request Jul 8, 2022
@MoLow @aduh95
test_runner: expose describe and it
354cc23 
PR-URL: nodejs/node#43420
Refs: nodejs/node#43415
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
aduh95 pushed a commit to aduh95/node-core-test that referenced this pull request Jul 9, 2022
@MoLow @aduh95
feat: expose describe and it
56d86fa 
PR-URL: nodejs/node#43420
Refs: nodejs/node#43415
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
aduh95 pushed a commit to aduh95/node-core-test that referenced this pull request Jul 9, 2022
@MoLow @aduh95
feat: expose describe and it
e29cd3f 
PR-URL: nodejs/node#43420
Refs: nodejs/node#43415
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@MoLow @targos
test_runner: expose describe and it
4bda6e0 
PR-URL: #43420
Refs: #43415
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 12, 2022
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 31, 2022
@MoLow @targos
test_runner: expose describe and it
61a2ddc 
PR-URL: #43420
Refs: #43415
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request Aug 2, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@MoLow @guangwong
test_runner: expose describe and it
419cf50 
PR-URL: nodejs/node#43420
Refs: nodejs/node#43415
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@himself65 himself65 mentioned this pull request Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell left review comments
@benjamingr benjamingr benjamingr approved these changes
@ljharb ljharb Awaiting requested review from ljharb
@aduh95 aduh95 Awaiting requested review from aduh95
+1 more reviewer
@olivermrose olivermrose olivermrose left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. test_runner Issues and PRs related to the test runner subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.