node_crypto_bio: adjust external memory size - #1085
Closed
indutny wants to merge 1 commit into
Closed
Conversation
Adjust V8's external memory size when allocating buffers for TLS data to ensure that V8 has enough information to trigger the GC at right time.
Member
Author
|
Here are improvised graphs of TLSWrap lifetime without this patch:
And with this patch:
|
Member
Author
|
It seems to stabilize after 20 minutes in both cases. |
Member
Author
|
Not sure if the patch actually helps that much. |
Contributor
|
:/ |
Member
Author
|
@aredridel initial GC seems to be much better overall. |
Member
Author
|
@bnoordhuis LGTY? |
Member
There was a problem hiding this comment.
You can drop the explicit keyword here.
Member
|
LGTM with a suggestion. |
indutny
added a commit
that referenced
this pull request
Mar 8, 2015
Adjust V8's external memory size when allocating buffers for TLS data to ensure that V8 has enough information to trigger the GC at right time. PR-URL: #1085 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Member
Author
|
Landed in 8670613, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @bnoordhuis