String::localeCompare support required.

[luochen1990]

• Version: v7.9.0
• Platform: Windows 10 (64-bit)
• Subsystem: none

The following code will print ["矮", "笨", "吃", "a", "b", "c"] in a uptodate browser, which is expected. But nodejs will print ["a", "b", "c", "吃", "矮", "笨"] for the same code, which is not reasonable for chinese users.

console.log(['矮', '吃', '笨', 'a', 'c', 'b'].sort((a, b) => a.localeCompare(b, 'zh-Hans-CN')))

Hope the String::localeCompare() function can be supported better, this is very useful for non-english-speaking users. thx :)

[bnoordhuis]

Did you install the full-icu module? https://www.npmjs.com/package/full-icu

[hashseed]

Yup. String.prototype.localeCompare uses ICU. Without full ICU it probably won't return correct results.

[luochen1990]

Thx, you are right, I installed the full-icu module and with the environment variable 'NODE_ICU_DATA' setted I found it worked.

But I also find that the full-icu module is not required, node will work correctly if the icu data file (icudt58l.dat) is found, no matter whether require("full-icu") is given. And the full-icu module is not process the environment variable 'NODE_ICU_DATA' correctly when console.log(require("full-icu").datPath()). I think this should be explained somewhere since it is not a normal useage of a npm module.

[gibfahn]

Reopening this as it sounds like a documentation request.

[bnoordhuis]

cc @srl295

[srl295]

Don't require full-Icu just install it and follow the instructions it prints out when installed.

[gibfahn]

Closing again as it is explained at the top of the full-icu README. Thanks @srl295