Skip to content

fix: start CI when the duplicate check cannot query Jenkins - #1195

Merged
aduh95 merged 1 commit into
mainfrom
fix/ci-duplicate-check-fallback
Sep 17, 2026
Merged

aduh95 merged 1 commit into
mainfrom
fix/ci-duplicate-check-fallback

Conversation

@mcollina

Copy link
Copy Markdown
Member

ncu-ci run --check-for-duplicates fetches the most recent CI: build linked on the PR to compare its COMMIT_SHA_CHECK. When Jenkins no longer serves that build as JSON (it currently answers with an HTML error page for several node-test-pull-request builds, e.g. 77459), request.json() throws a SyntaxError, the whole run aborts and the Auto Start CI workflow labels the PR request-ci-failed on every attempt. See nodejs/node#65986 (comment).

Catch the failure of that lookup, warn, skip the duplicate check and start a new CI run instead. A matching COMMIT_SHA_CHECK still refuses to start a duplicate.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.78%. Comparing base (42e7103) to head (ce74e4a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
+ Coverage   58.74%   58.78%   +0.03%     
==========================================
  Files          53       53              
  Lines       10427    10437      +10     
==========================================
+ Hits         6125     6135      +10     
  Misses       4302     4302              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina
mcollina requested review from aduh95 and panva September 17, 2026 08:34
@aduh95
aduh95 merged commit a3dc22c into main Sep 17, 2026
11 checks passed
@aduh95
aduh95 deleted the fix/ci-duplicate-check-fallback branch September 17, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants