feat: add worker option to spawnTest - #67
Open
bavulapati wants to merge 1 commit into
Open
Conversation
bavulapati
force-pushed
the
feat/spawn-test-worker
branch
from
July 31, 2026 11:06
6d5aa66 to
dd9a852
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
spawnTest(file, { worker: true }), which runs the test file on a worker thread of the spawned child, plus aruntimeFeatures.workerflag to gate on. First consumer is the worker half oftest_instance_data(#66).Why an option on spawnTest rather than an in-process
runInWorker: a nativeprintffrom an addon writes to fd 1 directly, bypassing a worker's piped JS-level stdout, so observing a secondary environment's native output means capturing the host process's stdout. Upstream wraps its worker in a child process for the same reason.runtimeFeatures.workeris declared separately fromspawnbecause the two are independent - a browser has workers but no subprocesses.The worker inherits the child's execArgv, so harness globals reach it. Leaving the
Workerwithout anerrorhandler is deliberate: an unhandled worker error re-throws on the host thread, so a failing test file still exits non-zero with its stack on stderr.tests/harness/spawn-test-worker.jspins that, pluscwd.