chore: remove redundant 'use strict' from test files - #64
Merged
legendecas merged 2 commits intoJul 31, 2026
Conversation
Test files under tests/ are evaluated as ES modules, which are always in strict mode, so the directive carried over from the upstream CommonJS sources has no effect. Records the rule in the porting instructions as well, so it does not come back with the next port. Closes nodejs#41 Signed-off-by: hexbinoct <abubakarm@gmail.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
legendecas
approved these changes
Jul 31, 2026
github-project-automation
Bot
moved this from Need Triage
to Done
in Node-API Team Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41.
Test files under
tests/are evaluated as ES modules (package.jsonsets"type": "module", and the Node implementor spawns each file withnode --expose-gc --import harness.js <file>), and ES modules are alwaysstrict, so the directive the ports inherited from the upstream CommonJS
sources has no effect.
The issue listed 21 files. There are 37 now, including the four under
tests/harness/, since more ports landed after it was filed. All of themare covered here.
I also added a sentence to
.github/copilot-instructions.mdunder "PureECMAScript tests", so the directive does not come back with the next port,
which was the second half of the issue. Happy to move that into
AGENTS.mdinstead if #13 lands first.
Verified on Windows with MSVC:
npm run addons:buildthennpm run node:testgives 46/46 passing, and
npm run lintis clean.Claude Opus 5 did the sweep across the files and drafted this text; I reviewed
both.