Skip to content

chore: add check for jq to update.sh script - #2600

Merged
MikeMcC399 merged 1 commit into
nodejs:mainfrom
MikeMcC399:update-check-jq
Aug 8, 2026
Merged

chore: add check for jq to update.sh script#2600
MikeMcC399 merged 1 commit into
nodejs:mainfrom
MikeMcC399:update-check-jq

Conversation

@MikeMcC399

@MikeMcC399 MikeMcC399 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Description

Add a check to the update.sh script for the availability of the jq command.

Output instructions to install jq from https://jqlang.org/download/ if not found.

Motivation and Context

PR #2598 added some additional usage of jq in the update.sh script.

If an attempt is made to run ./update.sh without jq installed, the error messages are quite noisy and untidy.

Testing Details

On Ubuntu 24.04.4 LTS

git clone https://github.com/nodejs/docker-node
cd docker-node

sudo apt-get -y remove jq # if previously installed
./update.sh -h # confirm help is displayed
./update.sh 26 # confirm jq message displayed

sudo apt-get install jq
./update.sh -h # confirm help is displayed
./update.sh 26 # confirm update is run

Test logs

New output is:

**jq not installed**
Follow the instructions in https://jqlang.org/download/ to install

Other output, as previously.

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@MikeMcC399
MikeMcC399 marked this pull request as ready for review August 7, 2026 09:31

@MattIPv4 MattIPv4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jq was already used in the script prior to that change, so I'm surprised this hasn't been an issue before!

@MikeMcC399

Copy link
Copy Markdown
Contributor Author

@MattIPv4

I also corrected the text in this PR.

@nschonni

nschonni commented Aug 8, 2026

Copy link
Copy Markdown
Member

jq was already used in the script prior to that change, so I'm surprised this hasn't been an issue before!

I added it recently for the achitecture parsing

@MikeMcC399
MikeMcC399 merged commit 8539305 into nodejs:main Aug 8, 2026
3 checks passed
@MikeMcC399
MikeMcC399 deleted the update-check-jq branch August 8, 2026 05:57
@MikeMcC399

Copy link
Copy Markdown
Contributor Author

jq was already used in the script prior to that change, so I'm surprised this hasn't been an issue before!

I added it recently for the achitecture parsing

That explains why I thought jq wasn't used. I was going on memory, when I'd looked at the repo prior to merge of #2494 at the end of last month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants