Old style exception --> new style for Python 3 - #1639
Merged
Conversation
Python 3 treats old style exceptions are syntax errors but new style exceptions work as expected in both Python 2 and Python 3. @rvagg Your review please?
Member
|
I'm really not the person that should be reviewing this, if it works on 2 & 3 then great, I guess. 👍 anyone else want to weigh in? |
Contributor
Author
|
@Trott @richardlau @addaleax,@BridgeAR @thefourtheye Your reviews please. |
BridgeAR
approved these changes
Dec 19, 2018
addaleax
approved these changes
Dec 19, 2018
thefourtheye
approved these changes
Dec 19, 2018
thefourtheye
left a comment
thefourtheye
left a comment
There was a problem hiding this comment.
LGTM, although the try...except could be removed in this particular case to get better stacktrace.
richardlau
approved these changes
Dec 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old style exceptions are syntax errors in Python 3 but new style exceptions work as expected in both Python 2 and Python 3. @rvagg Your review please?