Skip to content

When using version 3.x, if an error occurs in writeStream, no error will be thrown #459

Description

@PeterRao
const fs = require('fs');
const { request } = require('urllib');
const writeStream = fs.createWriteStream(__dirname + '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/not-exist/test.js').on('error', (e) => {
  console.log('folder not exist');
})

request('https://aaaaddd.oss-cn-zhangjiakou.aliyuncs.com/%E6%96%B0%E5%BB%BA%E6%96%87%E6%9C%AC%E6%96%87%E6%A1%A3.txt', {
  writeStream: writeStream
}).then(data => {
  console.log('success');
}).catch(e => {
  console.log('error', e.message);
})

use 2.33.1

folder not exist
error ENOENT: 

use 3.17.1

folder not exist
success

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions