Since re2c is often ignored in pull requests, it may make sense to make a contributing.md file #175

Activity

1. nlohmann

   self-assigned this

   on Jan 11, 2016
2. nlohmann

   added

   kind: enhancement/improvement

   on Jan 11, 2016
3. nlohmann commented on Jan 11, 2016

   

   nlohmann

   on Jan 11, 2016

   Owner

   More actions

   Thanks @whackashoe for noting this. Each time I commented on pull requests, I thought about writing such a file, but I always forget afterward. It's good to have this on the list here now. I shall try to merge this with the FAQ (#163).
4. nlohmann

   added a commit that references this issue on Jan 13, 2016

   contribution guidelines (#175)

   1741e58
5. nlohmann commented on Jan 13, 2016

   

   nlohmann

   on Jan 13, 2016

   Owner

   More actions

   I added some guidelines. Please tell me what you think!
6. nlohmann

   added

   state: please discussplease discuss the issue or vote for your favorite optionplease discuss the issue or vote for your favorite option

   on Jan 13, 2016
7. gregmarr commented on Jan 13, 2016

   

   gregmarr

   on Jan 13, 2016

   Contributor

   More actions

   Looks good. There are a couple places under files to change bullet 1 where you use src.json.hpp instead of src/json.hpp.
8. nlohmann commented on Jan 13, 2016

   

   nlohmann

   on Jan 13, 2016

   Owner

   More actions

   Ooops. I fixed it.
9. nlohmann

   added this to the Release 1.0.1This milestone has been deleted milestone on Jan 13, 2016
10. twelsby commented on Jan 19, 2016

    

    twelsby

    on Jan 19, 2016

    Contributor

    More actions

    This is a small thing but perhaps add something about testing under Valgrind as occasionally (as I found out to my surprise in pull request #183) it can yield different results to a vanilla run.
11. nlohmann

    added a commit that references this issue on Jan 20, 2016

    added a note wrt. Valgrind (#175)

    f854410
12. nlohmann

    removed

    state: please discussplease discuss the issue or vote for your favorite optionplease discuss the issue or vote for your favorite option

    on Jan 20, 2016
13. nlohmann commented on Jan 20, 2016

    

    nlohmann

    on Jan 20, 2016

    Owner

    More actions

    Thanks for the feedback!
14. nlohmann

    closed this as completedon Jan 20, 2016
15. nlohmann

    added

    kind: improvement

    on Nov 13, 2016