Repository navigation
create a header-only version #16
Description
Activity
Or people can just include the cpp file.
I don't really see the advantage of making it header only.It can improve compile time when precompiled headers are used and allows easy include only usage. The cpp file always has to be supplied to the compiler (which is mostly done by build tools that assume everything in one root) and therefore encourages adding the source directly in projects instead of just pulling them from a central include path.
Unfortunatly the cpp world has no ultimate solution to dependencies, packaging, etc. so I don't know if this is an advantage for others.
Have you already seen biicode ? They are really active in bringing a dependency solution for C++.
I've seen it and it seems pretty cool, but I don't want to rely on proprietary tools. I couldn't find a statement about escrow or plans for worst case.
- added a commit that references this issue
on Jan 9, 2015 @PaulFreund - could you check if the file
header_only/json.hsuits your needs?Should we really push the generated header only version to the repository? It's a generated file similar to a binary and should be hosted somewhere else.
I thought about it and thought the way Catch are doing it is reasonable. In the end, creating the header requires tools such as
catandsed. While they may be standard on some machines, they are not for Windows. Once the code is reasonably stable, one could think about using GitHub's release feature.@Teemperor, what do you think?
I think a release on Github from time to time is the best solution right now. It's just slightly more work compared to pushing the header file to git and it keeps the repository clean.
If we want this automated, we could also just run the header generation on a external server and serve it over HTTPS (or use the Github API to create releases).
Apart from the issue of how to publish the header-only version, I think we are done here.
Sorry for the late reply. Unfortunately just copying header and source together won't be enough. While free functions could be inlined, the member functions that are defined outside of their class declarations can't.
From my point of view there are only upsides for developing the library completely header only but I understand that it might also be a matter of taste.
Thanks @PaulFreund for your reply.
As I have no experience in creating a header-only version, I assumed that copying the sources would be enough. Can you give me more insights why this is not sufficient or point me to sources that explain how to do this properly?
you'll get duplicated symbols if you include it more than once
You are right. I did not check for a case where the header is included in several files. :-(
👍 for header only version.
- added a commit that references this issue
on Feb 5, 2015 👍 for header-only version. I'm very happy with this library but I had to do my own temporary patching (inlining) so that I could use it in my own header-only libraries.
Fixed in latest commit: the class is now header-only.
👏
- added a commit that references this issue
on May 7, 2021 - added a commit that references this issue
on Sep 26, 2024
As wished in http://www.reddit.com/r/cpp/comments/2rbhn3/json_for_modern_c_what_if_json_was_part_of_modern/cnelnzq:
And as I wrote: