aws-batch: Handle connection errors gracefully - #542
Merged
Conversation
Instead of crashing with an unhandled traceback when network connectivity to AWS Batch is lost, raise a UserError instructing the user how to re-attach to the job once connection is restored. Add a new helper function reattach_cmd() for use in both detach() and connection error handlers.
joverlee521
approved these changes
Aug 10, 2026
Comment on lines
+197
to
+204
| except botocore.exceptions.ConnectionError as error: | ||
| raise UserError(f""" | ||
| Lost connection with AWS Batch. | ||
|
|
||
| Re-attach with: | ||
|
|
||
| {reattach_cmd(opts.attach, local_workdir)} | ||
| """) from error |
Contributor
There was a problem hiding this comment.
non-blocking nit
Should this just be raised within JobState.update?
Member
Author
There was a problem hiding this comment.
I think it's useful to have the reattach command in the error message, and that's only available in run().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Instead of crashing with an unhandled traceback when network connectivity to AWS Batch is lost, raise a UserError instructing the user how to re-attach to the job once connection is restored.
Add a new helper function reattach_cmd() for use in both detach() and connection error handlers.
Related issue(s)
Error mentioned on Slack
Checklist