Repository navigation
feat: light theme and configurable accent color - #210
Merged
Merged
Conversation
nextestudios
force-pushed
the
feature/37-light-theme-accent
branch
2 times, most recently
from
September 27, 2026 22:47
1c4f781 to
0dcdb32
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nextestudios
force-pushed
the
feature/37-light-theme-accent
branch
from
September 27, 2026 22:52
0dcdb32 to
b54ec5d
Compare
Owner
Author
|
Smoke (screens mode; 1-home, 2-folder, 4b and 7* at 1920x1080 and 1280x720): the dark captures match the references, and the light and accent captures look right. A follow-up commit puts a dark plate behind the logo on the light theme, because the wordmark is light. One smoke attempt crashed at startup (exit 0xC000027B, before any capture). The rerun of the same commit passed, so this looks like a pre-existing flake, but it's worth watching. One CI attempt failed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Light theme and configurable accent color (#37).
ThemePalettes: dark (the current navy look, unchanged by default in dark mode) and light palettes. Each of 6 accent presets (cyan, blue, green, amber, magenta, orange) has a bright variant for dark (dark text on the focused fill) and a deep variant for light (white text on the fill).ThemeContrastcomputes the WCAG contrast ratio.AppSettings.Theme(Systemby default, follows Windows' app mode;Dark;Light) andAppSettings.Accent. They live in Menu → Configurações → Exibição → Tema / Cor de destaque. Both cycle and keep Configurações open, so the change can be compared right away with the controller.Themebrushes are shared by every view.Theme.Apply(palette)only changes theirColor, so everything already on screen recolors instantly.MainWindow.ApplyThemeresolves the automatic mode (UISettingsbackground, re-evaluated onColorValuesChanged), setsRequestedThemefor system controls, and runsApplyLayoutto rebuild derived colors (details gradient). Retained modals includeTheme.Revisionin their key. The hardcoded details gradient color became a token; the fixed light glyph palette no longer snapshots the theme.7-light-folder,7b-light-menu,7c-light-keyboard,7d-light-accent-magentaand7e-dark-accent-amber.Tests (CI)
ThemeContrastTests: every theme × accent (12 combinations) meets the targets. Text, secondary text and danger ≥ 4.5:1 on all surfaces. Focus ring, marked and success ≥ 3:1. The focused filled option (accent, danger and disabled) ≥ 4.5:1. Text on the focused item ≥ 4.5:1. The automatic mode follows Windows.AppearanceJourneyTests: theme/accent chosen in Configurações, which stays open; the change is published to the window at once and persists across launches.Manual (not hardware validated)
docs/TESTING.md→ "Tema claro e cor de destaque (#37)": live switch with Windows' app mode, TV-distance focus visibility per accent, no stray dark surfaces in light mode, and solid/high-contrast fallback.Docs: CHANGELOG (both), GUIDE (both, new section), README (both),
ui-redesign.md(token note + regression row).Closes #37
🤖 Generated with Claude Code