Repository navigation
feat: unify modal UX with frosted panels, icons and filled focus - #173
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… content Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One modal system for every modal surface (menus, confirmations, warnings, errors, password/on-screen keyboard, Operations center and details, results, folder-picker menu, Properties, About, controller test/setup, image/text previews):
#0C1B2A) with ~22 px corners, thin light edge and ThemeShadow; header with a tone badge icon, title (UIAControlFS.ModalTitlekept) and context line; divider; scrollable body; footer with the current status message and the controller prompts inside the panel (sameControllerPromptProvider/glyphs, only working actions; the window footer hints fade out without reflow).ActionIconenum +ActionIcons.Glyph(Segoe Fluent/MDL2) +ActionIcons.IsDestructivein Core;MenuItem.Icon/Section,DialogOption.Icon,Modal.Icon/Subtitle,DialogModal.Progressset byAppController(no WinUI in Core/Application). Result/error dialogs get success/warning/error tone.AppController.SafeInitialFocusguarantees no menu/dialog opens focused on a destructive option. Narrator appends "ação perigosa".Theme.SolidSurfaces, fromUISettings.AdvancedEffectsEnabled/AccessibilitySettings.HighContrast, re-read onAdvancedEffectsEnabledChanged/ColorValuesChanged); Windows animations off → no transition. Only animation: 120 ms opacity on a new modal; input never waits.Tests
ModalSystemJourneyTests(4): icon for every menu option/dialog button across main menus and dialogs + every icon has a glyph; destructive flagged and never initial focus (menus and dialogs); input under a modal never reaches the screen (buttons, list click, tab click); nested modals (keyboard over Compactar dialog) close one at a time and restore focus.build/Test-UiAutomation.ps1: danger option now readsSair(the ⚠ moved from text to an icon); all other UIA checks unchanged. Smoke (UIA, launches, installer, render-screens) green on this branch.--render-screens: new capturesm1…m9(menu, destructive focus, delete confirmation frosted + solid, extract summary, password, password error, success result, error, operations, operation details, picker menu, About) at 1280×720, 1280×800, 1920×1080, 3840×2160 at 100% and 200%, plusicons/action-icons.png. All report "cabe" (fit). Reviewed visually.Manual (not hardware validated)
Added "Modais (#172)" to
docs/TESTING.md: TV distance, real Xbox/PlayStation/Nintendo/generic controllers, transparency off, high contrast, animations off, shadow (RenderTargetBitmap doesn't draw it), mouse, Narrator.Docs: CHANGELOG pair, GUIDE pair ("Menus and dialogs"),
docs/ui-redesign.md(phase M, modal tokens, matrix row).Closes #172
🤖 Generated with Claude Code